[route_check][dualtor] Ignore vlan neighbor route miss#2888
Merged
lolyu merged 7 commits intosonic-net:masterfrom Jul 13, 2023
Merged
[route_check][dualtor] Ignore vlan neighbor route miss#2888lolyu merged 7 commits intosonic-net:masterfrom
lolyu merged 7 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
prsunny
approved these changes
Jun 30, 2023
Contributor
prsunny
left a comment
There was a problem hiding this comment.
lgtm, @theasianpianist , please review as well
Contributor
|
@lolyu , can you please provide a link to the new PR that handles dualtor routes |
Contributor
Author
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Jul 13, 2023
What I did As the subject. This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840 Signed-off-by: Longxiang Lyu lolv@microsoft.com How I did it If any misses are found on dualtor, ignore those vlan neighbor misses. How to verify it UT and verify on testbed.
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 19, 2023
What I did As the subject. This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840 Signed-off-by: Longxiang Lyu lolv@microsoft.com How I did it If any misses are found on dualtor, ignore those vlan neighbor misses. How to verify it UT and verify on testbed.
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
What I did As the subject. This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: sonic-net#2840 Signed-off-by: Longxiang Lyu lolv@microsoft.com How I did it If any misses are found on dualtor, ignore those vlan neighbor misses. How to verify it UT and verify on testbed.
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
What I did As the subject. This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: sonic-net#2840 Signed-off-by: Longxiang Lyu lolv@microsoft.com How I did it If any misses are found on dualtor, ignore those vlan neighbor misses. How to verify it UT and verify on testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT ADO: 24443895
What I did
As the subject.
This PR is to leave the vlan neighbor route checking to
dualtor_neighbor_check.pyscript: #2840Signed-off-by: Longxiang Lyu lolv@microsoft.com
How I did it
If any misses are found on dualtor, ignore those vlan neighbor misses.
How to verify it
UT and verify on testbed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)