Complete Platform Validator PR#2857
Merged
isabelmsft merged 5 commits intosonic-net:masterfrom Jun 8, 2023
Merged
Conversation
qiluo-msft
previously approved these changes
May 31, 2023
qiluo-msft
reviewed
Jun 1, 2023
| if device_info.get_sonic_version_info()['asic_type'] == 'cisco-8000': | ||
| asic = "cisco-8000" | ||
| elif device_info.get_sonic_version_info()['asic_type'] == 'vs': | ||
| asic = "td2" |
Contributor
There was a problem hiding this comment.
This is not always true. Please check https://github.com/sonic-net/sonic-buildimage/blob/220ea74cbb7e5cc783a27d7ca9f966899d81b7b3/platform/vs/docker-sonic-vs/Dockerfile.j2#L176 #Closed
Contributor
Author
There was a problem hiding this comment.
Updated the PR to fully consider vs hwskus
qiluo-msft
reviewed
Jun 6, 2023
| if asic_type == 'broadcom' or asic_type == 'vs': | ||
| broadcom_asics = asic_mapping["broadcom_asics"] | ||
| for asic_shorthand, hwskus in broadcom_asics.items(): | ||
| if asic != "unknown": |
Contributor
Contributor
Author
There was a problem hiding this comment.
asic is set to "unknown" at the start of the function. It remains unknown until one of the specified asic types in the table is identified. The purpose of this particular check is to stop iterating over all possible broadcom asics once the asic is already identified.
Contributor
There was a problem hiding this comment.
If it is already identified as spc1, you can return immediately.
Contributor
Author
There was a problem hiding this comment.
Changed to return spc1 immediately
qiluo-msft
approved these changes
Jun 7, 2023
This was referenced Jun 17, 2023
Contributor
Author
|
PR to cherry-pick to 202205 branch: #2883 |
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Jun 19, 2023
Cherry-pick PR 2692, 2818, and 2857 to 202205
yxieca
pushed a commit
that referenced
this pull request
Jun 23, 2023
* [GCU] Complete RDMA Platform Validator PR (#2857) Cherry-pick PR 2692, 2818, and 2857 to 202205
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Jul 12, 2023
This reverts commit 788db8c.
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Aug 10, 2023
…ic-net#2883) * [GCU] Complete RDMA Platform Validator PR (sonic-net#2857) Cherry-pick PR 2692, 2818, and 2857 to 202205
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Nov 22, 2023
yxieca
pushed a commit
that referenced
this pull request
Nov 29, 2023
Cherry-pick PR #2692 (set up test infrastructure used in later PR 2857), #2857 (platform validator PR), #2913 (edge case fix), #2951, #3018 (add support for new Mellanox HwSKU in conf file) This change stops GCU from modifying a protected RDMA field. Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original platform validator PR https://github.com/sonic-net/sonic-utilities/pull/2791/checks?check_run_id=12708751588 was merged and reverted due to unexpected test case behavior blocking submodule advance. This was fixed by specifically considering the virtual switch platform and identifying the appropriate ASIC. Now, this platform validator PR brings back the original changes
ADO 17747379