Update the DBmigrator to support persistent loglevel during warm-upgrade by EdenGri · Pull Request #2370 · sonic-net/sonic-utilities

EdenGri · 2022-09-14T07:50:59Z

This PR needs to be merged only after the following PR: sonic-net/sonic-buildimage#11996

What I did

Add the ability to the user to save the loglevel and make it persistent to reboot with the support in warm-upgrade. (Not need to add special support for cold/fast reboot since the LOGLEVEL DB flushes during fast/cold reboot).

How I did it

Add a new version to the db_migrator that will move the logger tables from the LOGLEVEL DB to the CONFIG DB

How to verify it

start with a switch that has an old master image (old master means that the VERSION in the config db is 3_0_5 or lower)
install this image to the switch
run warm-reboot
verify that the LOGLEVEL DB does not contain logger tables -> run redis-cli -n 3 keys "*" (expect to see only the JINJA2CACHE)
verify that the logger tables are in the config db -> run redis-cli -n 4 keys "LOGGER|*"

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

EdenGri · 2022-09-14T13:09:11Z

/azpw run

mssonicbld · 2022-09-14T13:09:12Z

/AzurePipelines run

azure-pipelines · 2022-09-14T13:09:24Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2022-09-20T21:55:25Z

Could you refine the PR title?

EdenGri · 2022-10-02T10:36:17Z

Done, thanks @qiluo-msft

EdenGri · 2022-10-06T07:24:41Z

/azpw run

mssonicbld · 2022-10-06T07:24:43Z

/AzurePipelines run

azure-pipelines · 2022-10-06T07:24:53Z

Azure Pipelines successfully started running 1 pipeline(s).

…it's content to CONFIG DB

…r LOGLEVEL DB

qiluo-msft · 2022-10-24T22:04:01Z

bandit checker is not 'Required', so please go ahead and merge it.

vaibhavhd · 2022-10-24T22:15:46Z

    },
    "VERSIONS|DATABASE": {
-        "VERSION": "version_3_0_5"
+        "VERSION": "version_3_0_3"


Why is this change needed? Is this relevant to persistance loglevel design?

Yes, relevant to persistance loglevel design.

I see. I am unable to understand, can you explain why tests for reclaiming-buffer need to be changed for persistence log-level design?

Hi @vaibhavhd
This is to change it back, correcting an error caused by an old PR. Refer this comment for details

Update sonic-utilities submodule pointer to include the following: * 4a3d49d Fix exception in adding mirror_session when gre_type is absent ([sonic-net#2458](sonic-net/sonic-utilities#2458)) * 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade ([sonic-net#2370](sonic-net/sonic-utilities#2370)) * c2841b8 [doc]: Update Command-Reference.md ([sonic-net#2444](sonic-net/sonic-utilities#2444)) * 254cafc Event Counters CLI ([sonic-net#2449](sonic-net/sonic-utilities#2449)) * 2dab0d0 [techsupport] Adding FRR EVPN dumps ([sonic-net#2442](sonic-net/sonic-utilities#2442)) * 3c0aece [show][muxcable] add support for show mux firmware version all ([sonic-net#2441](sonic-net/sonic-utilities#2441)) Signed-off-by: dprital <drorp@nvidia.com>

…ade (sonic-net#2370) - What I did Add the ability to the user to save the loglevel and make it persistent to reboot with the support in warm-upgrade. (Not need to add special support for cold/fast reboot since the LOGLEVEL DB flushes during fast/cold reboot). - How I did it Add a new version to the db_migrator that will move the logger tables from the LOGLEVEL DB to the CONFIG DB - How to verify it 1. start with a switch that has an old master image (old master means that the VERSION in the config db is 3_0_5 or lower) 2. install this image to the switch 3. run warm-reboot 4. verify that the LOGLEVEL DB does not contain logger tables -> run redis-cli -n 3 keys "*" (expect to see only the JINJA2CACHE) 5. verify that the logger tables are in the config db -> run redis-cli -n 4 keys "LOGGER|*"

EdenGri mentioned this pull request Sep 14, 2022

Persistent loglevel HLD sonic-net/SONiC#1041

Merged

dprital marked this pull request as draft September 14, 2022 10:29

dprital marked this pull request as ready for review September 19, 2022 11:18

dprital requested a review from qiluo-msft September 20, 2022 15:49

qiluo-msft requested a review from yxieca September 20, 2022 21:55

yxieca previously approved these changes Sep 28, 2022

View reviewed changes

EdenGri changed the title ~~Persistent loglevel~~ Update the DBmigrator to support persistent loglevel during warm-upgrade Oct 2, 2022

qiluo-msft previously approved these changes Oct 6, 2022

View reviewed changes

stephenxs reviewed Oct 12, 2022

View reviewed changes

Comment thread tests/db_migrator_input/config_db/reclaiming-buffer-warmreboot-expected.json Outdated

EdenGri dismissed stale reviews from qiluo-msft and yxieca via 3843adf October 12, 2022 15:56

EdenGri added 9 commits October 12, 2022 16:07

start adding warm upgrate support for removin LOGLEVEL DB and moving …

f9588ce

…it's content to CONFIG DB

update

d16e29e

fix conflict

cfa5c7d

bug fix: change del function name to del_table

0a7ba3e

bug fix: change the loglevel and logoutput, change delete function fo…

d7da6e1

…r LOGLEVEL DB

remove debug prints

7949a37

remove todo

13a7b0e

fixes after code review

ca00de5

Add unit test for the db_migrator

1563769

EdenGri force-pushed the persistent_loglevel branch from 803167a to 1563769 Compare October 12, 2022 16:07

add state db warm reboot enable flag

d77cd0f

EdenGri added 2 commits October 13, 2022 12:46

remove unused file

4c3eae2

bug fix: return the version to the original expected version

31fe28d

EdenGri requested review from qiluo-msft and yxieca and removed request for qiluo-msft and yxieca October 13, 2022 13:45

stephenxs approved these changes Oct 14, 2022

View reviewed changes

EdenGri requested review from qiluo-msft and removed request for yxieca October 19, 2022 06:46

qiluo-msft approved these changes Oct 19, 2022

View reviewed changes

qiluo-msft requested a review from vaibhavhd October 19, 2022 20:20

EdenGri requested review from yxieca and removed request for vaibhavhd October 20, 2022 07:05

dprital requested a review from vaibhavhd October 23, 2022 07:52

yxieca approved these changes Oct 24, 2022

View reviewed changes

vaibhavhd reviewed Oct 24, 2022

View reviewed changes

vaibhavhd approved these changes Oct 24, 2022

View reviewed changes

liat-grozovik mentioned this pull request Oct 25, 2022

Add a yang model for the new "Logger" table in the CONFIG DB sonic-net/sonic-buildimage#12067

Merged

7 tasks

liat-grozovik merged commit 7e7d05c into sonic-net:master Oct 25, 2022

dprital mentioned this pull request Oct 28, 2022

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#12544

Merged

7 tasks

Conversation

EdenGri commented Sep 14, 2022 • edited by liat-grozovik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

EdenGri commented Sep 14, 2022

Uh oh!

mssonicbld commented Sep 14, 2022

Uh oh!

azure-pipelines Bot commented Sep 14, 2022

Uh oh!

qiluo-msft commented Sep 20, 2022

Uh oh!

EdenGri commented Oct 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EdenGri commented Oct 6, 2022

Uh oh!

mssonicbld commented Oct 6, 2022

Uh oh!

azure-pipelines Bot commented Oct 6, 2022

Uh oh!

Uh oh!

qiluo-msft commented Oct 24, 2022

Uh oh!

vaibhavhd Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

vaibhavhd Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

stephenxs Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

EdenGri commented Sep 14, 2022 •

edited by liat-grozovik

Loading

EdenGri commented Oct 2, 2022 •

edited

Loading

stephenxs Oct 24, 2022 •

edited

Loading