Skip to content

[warm/fast-reboot] Fix kexec portion to support platforms based on De…#1966

Merged
yxieca merged 1 commit intosonic-net:masterfrom
dflynn-Nokia:fast-reboot-devtree
Dec 17, 2021
Merged

[warm/fast-reboot] Fix kexec portion to support platforms based on De…#1966
yxieca merged 1 commit intosonic-net:masterfrom
dflynn-Nokia:fast-reboot-devtree

Conversation

@dflynn-Nokia
Copy link
Copy Markdown
Contributor

…vice Tree

The warm-reboot and fast-reboot commands currently expect a platform that uses
GRUB. Information about the current kernel boot arguments is extracted from
the GRUB config file. This commit adds support for platforms that do not use
GRUB but rather use Device Tree to define the current kernel boot arguments.
Example platform architectures using Device Tree include armhf and arm64.

This commit also includes a minor improvement to a similar change made to the
soft-reboot command in PR# 1963

What I did

Fix kexec portion of warm-reboot and fast-reboot commands for the armhf and arm64 platforms

How I did it

Add logic to retrieve kernel boot arguments from the Device Tree rather than from the GRUB config for these platforms

How to verify it

Execute the warm-reboot and fast-reboot commands on an armhf or arm64 platform and confirm that kexec reboots the switch as expected

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…vice Tree

The warm-reboot and fast-reboot commands currently expect a platform that uses
GRUB.  Information about the current kernel boot arguments is extracted from
the GRUB config file. This commit adds support for platforms that do not use
GRUB but rather use Device Tree to define the current kernel boot arguments.
Example platform architectures using Device Tree include armhf and arm64.

This commit also includes a minor improvement to a similar change made to the
soft-reboot command in PR# 1963
@qiluo-msft
Copy link
Copy Markdown
Contributor

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@dflynn-Nokia
Copy link
Copy Markdown
Contributor Author

I submitted PR# 1980 to deliver the fix the 202012 branch.

judyjoseph pushed a commit that referenced this pull request Jan 9, 2022
…vice Tree (#1966)

The warm-reboot and fast-reboot commands currently expect a platform that uses
GRUB.  Information about the current kernel boot arguments is extracted from
the GRUB config file. This commit adds support for platforms that do not use
GRUB but rather use Device Tree to define the current kernel boot arguments.
Example platform architectures using Device Tree include armhf and arm64.

This commit also includes a minor improvement to a similar change made to the
soft-reboot command in PR# 1963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants