Skip to content

[debug dump] Refactoring Modules and Unit Tests#1943

Merged
SuvarnaMeenakshi merged 2 commits intosonic-net:masterfrom
vivekrnv:debug_dump_refactoring
Nov 30, 2021
Merged

[debug dump] Refactoring Modules and Unit Tests#1943
SuvarnaMeenakshi merged 2 commits intosonic-net:masterfrom
vivekrnv:debug_dump_refactoring

Conversation

@vivekrnv
Copy link
Copy Markdown
Contributor

@vivekrnv vivekrnv commented Nov 24, 2021

What I did

  1. Moved the "populate_mock" method to dump/helper.py i.e. common to all the tests
  2. Moved the "add_to_ret_template" to Executor class i.e. common across all the modules.

How I did it

How to verify it

Unit Tests's:

vkarri@96050efd4f16:/sonic/src/sonic-utilities$ pytest-3 tests/dump_tests/ 
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0
rootdir: /sonic/src/sonic-utilities/tests, configfile: pytest.ini
plugins: pyfakefs-4.5.3, cov-2.10.1
collected 116 items                                                                                                                                                        

tests/dump_tests/dump_state_test.py .............                                                                                                                    [ 11%]
tests/dump_tests/match_engine_test.py ...............................                                                                                                [ 37%]
tests/dump_tests/module_tests/copp_test.py ..........                                                                                                                [ 46%]
tests/dump_tests/module_tests/evpn_test.py ......                                                                                                                    [ 51%]
tests/dump_tests/module_tests/port_test.py ......                                                                                                                    [ 56%]
tests/dump_tests/module_tests/portchannel_member_test.py ...                                                                                                         [ 59%]
tests/dump_tests/module_tests/portchannel_test.py ....                                                                                                               [ 62%]
tests/dump_tests/module_tests/route_test.py ..........                                                                                                               [ 71%]
tests/dump_tests/module_tests/vlan_test.py .....................                                                                                                     [ 89%]
tests/dump_tests/module_tests/vxlan_tunnel_map_test.py .....                                                                                                         [ 93%]
tests/dump_tests/module_tests/vxlan_tunnel_test.py .......                                                                                                           [100%]

=========================================================================== 116 passed in 1.21s ============================================================================

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@vivekrnv
common methods moved to executor class
3f7f032 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Tests Refactored
666149e 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Copy link
Copy Markdown
Contributor Author

vivekrnv commented Nov 24, 2021

@SuvarnaMeenakshi, Can you help review

@dgsudharsan
Copy link
Copy Markdown
Collaborator

dgsudharsan commented Nov 25, 2021

@SuvarnaMeenakshi Your code review comments are handled here. Can you please review and signoff?

SuvarnaMeenakshi
SuvarnaMeenakshi reviewed Nov 30, 2021
View reviewed changes
Comment thread dump/plugins/executor.py
SuvarnaMeenakshi
SuvarnaMeenakshi approved these changes Nov 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuvarnaMeenakshi SuvarnaMeenakshi merged commit 4e132c1 into sonic-net:master Nov 30, 2021
@vivekrnv vivekrnv deleted the debug_dump_refactoring branch December 6, 2021 17:00
@aravindmani-1 aravindmani-1 mentioned this pull request Dec 8, 2021
Closed
5 tasks
@DavidZagury DavidZagury mentioned this pull request Dec 8, 2021
Closed
5 tasks
abdosi pushed a commit that referenced this pull request Dec 8, 2021
@vivekrnv @abdosi
[debug dump] Refactoring Modules and Unit Tests (#1943)
76cc67b 
What I did
Moved the "populate_mock" method to dump/helper.py i.e. common to all the tests
Moved the "add_to_ret_template" to Executor class i.e. common across all the modules.
How I did it
How to verify it
Unit Tests's:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuvarnaMeenakshi SuvarnaMeenakshi SuvarnaMeenakshi approved these changes

Assignees

No one assigned

Labels

Included in 202111 Branch Request for 202111 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vivekrnv @dgsudharsan @SuvarnaMeenakshi @judyjoseph