Skip to content

Reorder dependencies to fix wheel build#117

Merged
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_wheel_build
Oct 4, 2017
Merged

Reorder dependencies to fix wheel build#117
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_wheel_build

Conversation

@jleveque
Copy link
Copy Markdown
Contributor

@jleveque jleveque commented Oct 4, 2017

  • Dependencies listed in install_requires are installed in reverse order, so click-default-group must precede click

@jleveque jleveque self-assigned this Oct 4, 2017
@jleveque jleveque requested review from lguohan and taoyl-ms October 4, 2017 23:30
@jleveque jleveque merged commit 2c63a41 into sonic-net:master Oct 4, 2017
@jleveque jleveque deleted the fix_wheel_build branch October 4, 2017 23:32
zhenggen-xu pushed a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
* msft_github/master:
  Reorder dependencies to fix wheel build (sonic-net#117)
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
…onic-net#117)

Previously, psud assumed that the swsscommon library would not be installed in the unit testing environment. This is not a valid assumption, and would cause unit tests to fail if swsscommon was available in the unit test environment, because it would get imported, but there would be no Redis DB to communicate with.

This PR uses environment variables, which are set by the unit tests themselves, to determine whether to load the real or mock libraries. This solution is similar to what is done in sonic-utilities.
cyw233 pushed a commit to cyw233/sonic-utilities that referenced this pull request Mar 2, 2026
<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "closes #xxxx",
 "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
 issue when the PR is merged.

 If you are adding/modifying/removing any command or utility script, please also
 make sure to add/modify/remove any unit tests from the tests
 directory as appropriate.

 If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
 subcommand, or you are adding a new subcommand, please make sure you also
 update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
 your changes.

 Please provide the following information:
-->

Currently, in Cisco 8800 chassis, PFCWD is only enabled for front end ports, not on backplane. As we have PFC enabled for backplane ports, need to enable pfcwd there too.

#### What I did.
Enable PFCWD for backplane ports.

#### How I did it
Include backplane ports into the port list to be enabled for pfcwd

#### How to verify it

manually copied the file to device, and run pfcwd start_default.

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants