[mclag]:add mclagsyncd#811
Merged
rlhui merged 14 commits intosonic-net:masterfrom Mar 22, 2020
Merged
Conversation
pull from origin
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
added 2 commits
March 18, 2019 19:58
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
lisahnguyen
reviewed
Jul 29, 2019
gitsabari
reviewed
Aug 3, 2019
gitsabari
reviewed
Aug 16, 2019
stcheng
suggested changes
Aug 21, 2019
Contributor
stcheng
left a comment
There was a problem hiding this comment.
please address the comments
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
lisahnguyen
previously approved these changes
Sep 18, 2019
lisahnguyen
left a comment
There was a problem hiding this comment.
Thanks for addressing my review comment.
gitsabari
previously approved these changes
Sep 18, 2019
Contributor
gitsabari
left a comment
There was a problem hiding this comment.
thanks for taking care of review comments
Signed-off-by: shine.chen <shine.chen@mediatek.com>
Contributor
Author
|
retest this please. |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
Signed-off-by: shine.chen <shine.chen@mediatek.com>
…into mclagsyncd
Contributor
Author
|
retest this please |
Contributor
|
I saw binary in the pr. please remove the binary. |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
Contributor
Author
|
@lguohan Thanks, done |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
rlhui
previously approved these changes
Nov 22, 2019
Contributor
Author
|
retest this please |
stcheng
previously approved these changes
Nov 26, 2019
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
b44975f
Contributor
Author
|
@stcheng @rlhui @gitsabari @lisahnguyen I resolved some conflict and system automatically dismiss your approve. Would you please help to review and approve it again ? |
rlhui
approved these changes
Feb 24, 2020
lisahnguyen
approved these changes
Feb 24, 2020
gitsabari
approved these changes
Feb 24, 2020
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…#811) **What I did** Fix the issue of ignoring callback calls for removed keys. **Why I did it** ConfigDBConnector.listen method has a caching mechanism (added in sonic-net/sonic-swss-common#587 PR) that preloads the DB state before starting. When the notification about the changed key is received the listen method gets key data from the DB (in all cases when the key was added, updated, or removed) and compares the data with the cache. It fires the callback only if data differ from the cache. Otherwise, the callback is ignored. If the `client.hgetall(key)` is called for the removed key it returns an empty dictionary (`{}`). This can be confused with the data of the key with no attributes. For example: `{"TABLE": {"KEY": {}}}`. So if preloaded data contains a key with no attributes and the listener method receives a notification about the removal of such key the callback is not called. The listener will simply remove the key from the cache without calling the callback. This leads to the situation when the removal of the key is not handled. The solution is to get data for the added or updated keys, and for the removed keys use `None` instead. This will ensure that the comparison with the cache will work as expected. **How I verified it** Compile the package and run the unit test. Unit tests are extended to cover the expected behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
add mclagsyncd
Why I did it
accomplish it according to MCLAG HLD document
How I verified it
test it on nephos lab
Details if related
Please refer #sonic-net/SONiC#325