Add p4orch by donNewtonAlpha · Pull Request #1997 · sonic-net/sonic-swss

donNewtonAlpha · 2021-11-01T16:42:04Z

What I did
Initial add of P4orch code
Why I did it

How I verified it

Details if related

lgtm-com · 2021-11-02T17:18:33Z

This pull request introduces 1 alert and fixes 4 when merging 97383d3 into e92c1df - view on LGTM.com

new alerts:

1 for Syntax error

fixed alerts:

2 for Unused local variable
2 for Unused import

lgtm-com · 2021-11-02T18:37:05Z

This pull request introduces 1 alert and fixes 4 when merging e57010d into e92c1df - view on LGTM.com

new alerts:

1 for Syntax error

fixed alerts:

2 for Unused local variable
2 for Unused import

lgtm-com · 2021-11-05T19:22:17Z

This pull request introduces 1 alert and fixes 4 when merging cf23384 into b20f0f4 - view on LGTM.com

new alerts:

1 for Syntax error

fixed alerts:

2 for Unused local variable
2 for Unused import

lgtm-com · 2021-11-13T02:40:15Z

This pull request introduces 4 alerts when merging 8107df0 into cdea5e9 - view on LGTM.com

new alerts:

4 for Unused import

lgtm-com · 2021-11-20T00:19:42Z

This pull request introduces 4 alerts when merging 893d843 into 797dab4 - view on LGTM.com

new alerts:

4 for Unused import

lgtm-com · 2021-11-20T06:22:02Z

This pull request introduces 4 alerts when merging fd07a5a into b91d8ba - view on LGTM.com

new alerts:

4 for Unused import

prsunny · 2021-11-22T21:46:27Z

/azp run

azure-pipelines · 2021-11-22T21:46:41Z

Azure Pipelines successfully started running 1 pipeline(s).

donNewtonAlpha · 2021-11-23T07:34:11Z

/azpw run

mssonicbld · 2021-11-23T07:34:12Z

/AzurePipelines run

azure-pipelines · 2021-11-23T07:34:23Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-11-23T15:14:27Z

/azp run

azure-pipelines · 2021-11-23T15:14:41Z

Azure Pipelines successfully started running 1 pipeline(s).

donNewtonAlpha · 2021-11-23T21:49:34Z

/azpw run

mssonicbld · 2021-11-23T21:49:36Z

/AzurePipelines run

azure-pipelines · 2021-11-23T21:49:46Z

Azure Pipelines successfully started running 1 pipeline(s).

bocon13 · 2021-11-24T03:01:57Z

Azure.sonic-swss (Test vstest) is timing out at 240 minutes. Otherwise the test looks good; it's probably resource starved because there's no new tests added by this PR.

test_watermark.py::TestWatermark::test_telemetry_period PASSED           [ 97%]
test_watermark.py::TestWatermark::test_lua_plugins SKIPPED               [ 97%]
test_watermark.py::TestWatermark::test_clear SKIPPED                     [ 97%]
test_watermark.py::test_nonflaky_dummy PASSED                            [ 98%]
##[error]The operation was canceled.
Finishing: Run vs tests

Once we get a clean run, this should be ready to merge.

lgtm-com · 2021-11-24T04:52:20Z

This pull request introduces 4 alerts when merging cc83d98 into 16d4bcd - view on LGTM.com

new alerts:

4 for Unused import

bocon13 · 2021-11-24T18:12:10Z

Tests seem to be failing in the same way as on master.

lgtm-com · 2021-11-24T19:09:14Z

This pull request introduces 4 alerts when merging a59298c into fb0a5fd - view on LGTM.com

new alerts:

4 for Unused import

lgtm-com · 2021-11-25T01:06:58Z

This pull request introduces 4 alerts when merging 4f6142d into fb0a5fd - view on LGTM.com

new alerts:

4 for Unused import

prsunny · 2021-11-25T05:44:39Z

/azp run

azure-pipelines · 2021-11-25T05:44:50Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2021-11-25T18:35:48Z

This pull request introduces 4 alerts when merging b29e4ce into 3d862a7 - view on LGTM.com

new alerts:

4 for Unused import

lgtm-com · 2021-11-25T23:14:35Z

This pull request introduces 4 alerts when merging dfdc9ab into 3d862a7 - view on LGTM.com

new alerts:

4 for Unused import

donNewtonAlpha · 2021-11-26T03:40:57Z

/azpw run

mssonicbld · 2021-11-26T03:41:00Z

/AzurePipelines run

azure-pipelines · 2021-11-26T03:41:10Z

Azure Pipelines successfully started running 1 pipeline(s).

mint570 · 2021-11-27T01:19:50Z

@prsunny
All tests have been passed. Please approve and merge this pr. Thanks.

prsunny · 2021-11-29T17:24:37Z

orchagent/p4orch/tests/mock_sai_udf.cpp

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2020 Google LLC


could you please remove the copyright? and also for any other files in the PR?

Submission containing materials of a third party: Copyright Google LLC; Licensed under Apache 2.0 Co-authored-by: Yilan Ji yilanji@google.com Co-authored-by: Manali Kumar manalikumar@google.com Co-authored-by: Akarsh Gupta akarshgupta@google.com Co-authored-by: Runming Wu runmingwu@google.com Co-authored-by: Jay Hu jiarenhu@google.com Co-authored-by: Howard Yang yhoward@google.com Co-authored-by: Mike Attig mikeattig@google.com Co-authored-by: Stephen Wang tingchun@google.com Co-authored-by: Brian O'Connor <bocon@opennetworking.org> Signed-off-by: Don Newton don@opennetworking.org

bocon13 · 2021-11-30T02:47:57Z

Rebased and re-running tests

bocon13 · 2021-11-30T11:50:44Z

@prsunny please take a look

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun stephens@nvidia.com

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

donNewtonAlpha requested a review from prsunny as a code owner November 1, 2021 16:42

donNewtonAlpha force-pushed the add-p4orch branch 3 times, most recently from 8b65f0f to 8107df0 Compare November 13, 2021 02:17

donNewtonAlpha force-pushed the add-p4orch branch from 893d843 to fd07a5a Compare November 20, 2021 05:13

bocon13 force-pushed the add-p4orch branch from 56241c5 to cc83d98 Compare November 24, 2021 03:29

mint570 force-pushed the add-p4orch branch from cc83d98 to a59298c Compare November 24, 2021 17:57

mint570 force-pushed the add-p4orch branch from 4f6142d to b29e4ce Compare November 25, 2021 17:29

mint570 force-pushed the add-p4orch branch from b29e4ce to dfdc9ab Compare November 25, 2021 22:08

bocon13 force-pushed the add-p4orch branch from d139dcc to 4aa6b4d Compare November 26, 2021 16:48

prsunny reviewed Nov 29, 2021

View reviewed changes

bocon13 mentioned this pull request Nov 30, 2021

PINS Upstream Tracking for MVP sonic-net/SONiC#841

Open

donNewtonAlpha force-pushed the add-p4orch branch from f7a72b7 to ce16f52 Compare November 30, 2021 02:47

prsunny approved these changes Nov 30, 2021

View reviewed changes

prsunny merged commit bcb7d61 into sonic-net:master Nov 30, 2021

bocon13 pushed a commit to pins/sonic-swss-public that referenced this pull request Nov 30, 2021

P4Orch: inital add of source (sonic-net#1997)

11c081f

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

bocon13 pushed a commit to pins/sonic-swss-public that referenced this pull request Nov 30, 2021

P4Orch: inital add of source (sonic-net#1997)

e90132b

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

bocon13 mentioned this pull request Nov 30, 2021

Orchagent: Integrate P4Orch #2029

Merged

stephenxs mentioned this pull request Dec 1, 2021

[sonic-swss] Submodule update sonic-net/sonic-buildimage#9397

Merged

5 tasks

stephenxs mentioned this pull request Jan 6, 2022

[sonic-swss][202111] Submodule update (#9397) sonic-net/sonic-buildimage#9685

Merged

5 tasks

mint570 deleted the add-p4orch branch July 22, 2022 16:38

preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022

P4Orch: inital add of source (sonic-net#1997)

ffcaa98

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025

P4Orch: inital add of source (sonic-net#1997)

9f837c1

Add P4orch code and subdir Co-authored-by: PINS Working Group <sonic-pins-subgroup@googlegroups.com>

Conversation

donNewtonAlpha commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Nov 2, 2021

Uh oh!

lgtm-com bot commented Nov 2, 2021

Uh oh!

lgtm-com bot commented Nov 5, 2021

Uh oh!

lgtm-com bot commented Nov 13, 2021

Uh oh!

lgtm-com bot commented Nov 20, 2021

Uh oh!

lgtm-com bot commented Nov 20, 2021

Uh oh!

prsunny commented Nov 22, 2021

Uh oh!

azure-pipelines bot commented Nov 22, 2021

Uh oh!

donNewtonAlpha commented Nov 23, 2021

Uh oh!

mssonicbld commented Nov 23, 2021

Uh oh!

azure-pipelines bot commented Nov 23, 2021

Uh oh!

prsunny commented Nov 23, 2021

Uh oh!

azure-pipelines bot commented Nov 23, 2021

Uh oh!

donNewtonAlpha commented Nov 23, 2021

Uh oh!

mssonicbld commented Nov 23, 2021

Uh oh!

azure-pipelines bot commented Nov 23, 2021

Uh oh!

bocon13 commented Nov 24, 2021

Uh oh!

lgtm-com bot commented Nov 24, 2021

Uh oh!

bocon13 commented Nov 24, 2021

Uh oh!

lgtm-com bot commented Nov 24, 2021

Uh oh!

lgtm-com bot commented Nov 25, 2021

Uh oh!

prsunny commented Nov 25, 2021

Uh oh!

azure-pipelines bot commented Nov 25, 2021

Uh oh!

lgtm-com bot commented Nov 25, 2021

Uh oh!

lgtm-com bot commented Nov 25, 2021

Uh oh!

donNewtonAlpha commented Nov 26, 2021

Uh oh!

mssonicbld commented Nov 26, 2021

Uh oh!

azure-pipelines bot commented Nov 26, 2021

Uh oh!

mint570 commented Nov 27, 2021

Uh oh!

prsunny Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

mint570 Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

bocon13 commented Nov 30, 2021

Uh oh!

bocon13 commented Nov 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

donNewtonAlpha commented Nov 1, 2021 •

edited

Loading