Skip to content

integrating py.test into setuptools#103

Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom
samaity:snmp_stretch_helper
Apr 11, 2019
Merged

integrating py.test into setuptools#103
qiluo-msft merged 2 commits intosonic-net:masterfrom
samaity:snmp_stretch_helper

Conversation

@samaity
Copy link
Copy Markdown
Contributor

@samaity samaity commented Apr 11, 2019

Signed-off-by: Sangita Maity samaity@linkedin.com

  • What I did
    Integrate py.test into setuptools as vanilla 'python3 setup.py test' does not work.
    This PR is needed for snmp stretch upgrade docker PR.
  1. [dockers]: Upgrade SNMP docker to stretch build sonic-buildimage#2620
  • How to verify it
    Use this PR with snmp docker upgrade PR in sonic-buildimage.

Ref: https://docs.pytest.org/en/latest/goodpractices.html

@samaity
Copy link
Copy Markdown
Contributor Author

samaity commented Apr 11, 2019

@qiluo-msft, kindly review it. We need it for snmp docker upgrade to stretch.

@qiluo-msft
Copy link
Copy Markdown
Contributor

qiluo-msft commented Apr 11, 2019

    'testing': test_deps,

Can we remove this line? #Closed


Refers to: setup.py:26 in 33346ee. [](commit_id = 33346ee, deletion_comment = False)

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

@qiluo-msft qiluo-msft merged commit 70a6c7d into sonic-net:master Apr 11, 2019
@samaity samaity deleted the snmp_stretch_helper branch April 17, 2019 18:44
ssithaia-ebay pushed a commit to ssithaia-ebay/sonic-snmpagent that referenced this pull request May 23, 2025
* integrating py.test into setuptools
* removed test dependencies from extras_require and add it as test_require
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants