Skip to content

[ci]: Support code diff coverage#934

Merged
kcudnik merged 2 commits intosonic-net:masterfrom
xumia:azp-diff-cover
Sep 24, 2021
Merged

[ci]: Support code diff coverage#934
kcudnik merged 2 commits intosonic-net:masterfrom
xumia:azp-diff-cover

Conversation

@xumia
Copy link
Copy Markdown
Collaborator

@xumia xumia commented Sep 20, 2021

Support code diff coverage

  1. Support to add the pull request checks for Code diff coverage in GitHub.
  2. Support to display the code diff coverage html report in Azure Pipelines.

@xumia
Copy link
Copy Markdown
Collaborator Author

xumia commented Sep 22, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 22, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@xumia xumia marked this pull request as ready for review September 22, 2021 22:35
@xumia xumia requested a review from lguohan September 22, 2021 22:35
@xumia xumia marked this pull request as draft September 22, 2021 22:36
@xumia xumia requested a review from qiluo-msft September 23, 2021 03:29
@qiluo-msft qiluo-msft requested a review from kcudnik September 23, 2021 06:21
qiluo-msft
qiluo-msft reviewed Sep 23, 2021
View reviewed changes
@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Sep 23, 2021

how this entire feature should work ? is already framework for support that build in azpipeline and sairedis azpipeline configuration?

@xumia xumia marked this pull request as ready for review September 23, 2021 08:40
@xumia
Copy link
Copy Markdown
Collaborator Author

xumia commented Sep 23, 2021 •
edited
Loading

@kcudnik , I added an azure devops extension to support it, see https://github.com/Azure/sonic-build-web/tree/main/code-diff-coverage. Azure DevOps still does not support it. It is a workaround, so we do not need to change it in all sub-modules, only enable it by a variable flag.

qiluo-msft
qiluo-msft reviewed Sep 23, 2021
View reviewed changes
qiluo-msft
qiluo-msft previously approved these changes Sep 23, 2021
View reviewed changes
kcudnik
kcudnik previously approved these changes Sep 23, 2021
View reviewed changes
@xumia xumia dismissed stale reviews from kcudnik and qiluo-msft via 2e97f3a September 23, 2021 09:18
@xumia
Copy link
Copy Markdown
Collaborator Author

xumia commented Sep 24, 2021

@kcudnik , can we merge the code, there is one failure check, looks like it is not relative to the change.

@kcudnik kcudnik merged commit e545b17 into sonic-net:master Sep 24, 2021
@xumia xumia deleted the azp-diff-cover branch September 24, 2021 13:24
@xumia xumia restored the azp-diff-cover branch September 24, 2021 13:24
@xumia xumia deleted the azp-diff-cover branch September 24, 2021 13:24
@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Sep 25, 2021

your diff coverage plugin broken full coverage stats file by file:
https://dev.azure.com/mssonic/build/_build/results?buildId=39429&view=results

clicking you can't see any more how much covered is each added file , please revert your change or make it possible to view both results

pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@xumia
[ci]: Support code diff coverage (sonic-net#934)
a5826d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@kcudnik kcudnik kcudnik approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xumia @kcudnik @qiluo-msft