Skip to content

Revert "sonic-sairedis: Add support to sonic-sairedis for gearbox phys"#630

Merged
lguohan merged 1 commit intomasterfrom
revert-624-master
Jun 27, 2020
Merged

Revert "sonic-sairedis: Add support to sonic-sairedis for gearbox phys"#630
lguohan merged 1 commit intomasterfrom
revert-624-master

Conversation

@daall
Copy link
Copy Markdown
Contributor

@daall daall commented Jun 27, 2020

Reverts #624

It looks like the getSwitchType method isn't compatible with the SKUs we use in the VS tests.
https://github.com/Azure/sonic-sairedis/blob/9e2d0c437ca06240b529c3e9ef287c350c02b081/syncd/SaiSwitch.cpp#L140

Logs from https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/1286/:

Jun 27 03:38:01.877260 28c1f78229bb ERR #syncd: :- getSwitchType: failed to get switch type
Jun 27 03:38:01.877351 28c1f78229bb NOTICE #syncd: :- SaiSwitch: constructor took 0.744519 sec
Jun 27 03:38:01.877721 28c1f78229bb ERR #syncd: :- run: Runtime error: :- getSwitchType: failed to get switch type
Jun 27 03:38:01.877750 28c1f78229bb NOTICE #syncd: :- sendShutdownRequest: sending switch_shutdown_request notification to OA for switch: oid:0x0
Jun 27 03:38:01.877857 28c1f78229bb NOTICE #syncd: :- sendShutdownRequestAfterException: notification send successfull
Jun 27 03:38:01.878295 28c1f78229bb INFO #supervisord: orchagent terminate called after throwing an instance of 'std::invalid_argument'
Jun 27 03:38:01.878324 28c1f78229bb INFO #supervisord: orchagent   what():  parse error - unexpected 'o'
Jun 27 03:38:02.052109 28c1f78229bb INFO #supervisord: start.sh orchagent: ERROR (spawn error)

For reference we use the BCM56850 for most of the tests and the MLNX2700 for a few (like test_mirror_ipv6_separate).

I will work on getting these tests added to the sonic-sairedis repo over the weekend so that these are available for PRs going forward. Sorry for the fire drill everyone!

@daall daall requested review from jleveque, kcudnik and lguohan June 27, 2020 03:53
@lguohan lguohan merged commit 61b8e8e into master Jun 27, 2020
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@daall
Revert "sonic-sairedis: Add support to sonic-sairedis for gearbox phys (
b157e6d 
sonic-net#624)" (sonic-net#630)

This reverts commit 2772f15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque Awaiting requested review from jleveque

@kcudnik kcudnik Awaiting requested review from kcudnik

Assignees

No one assigned

Labels

Bug Critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daall @lguohan