Fix debian/rules makefile: use shell commands instead of dollar replacements#621
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Jun 6, 2020
Merged
Conversation
replacements because: 1. `ifeq` evaluates conditionals when it reads a Makefile. 2. no need to replace with shell command outputs ref: https://stackoverflow.com/a/11994561/2514803
jleveque
previously approved these changes
Jun 6, 2020
Contributor
|
@qiluo-msft: FYI, I made a small change to your description above. Looks good to me. Nice find! |
jleveque
previously approved these changes
Jun 6, 2020
jleveque
previously approved these changes
Jun 6, 2020
jleveque
approved these changes
Jun 6, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…cements (sonic-net#621) * Fix debian/rules makefile: use shell commands instead of dollar replacements because: 1. `ifeq` evaluates conditionals when it reads a Makefile. 2. no need to replace with shell command outputs ref: https://stackoverflow.com/a/11994561/2514803 * Fix one more `echo` * Revert back one shell replacement * Fix some bash command and Makefile escaping issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because:
makeevaluates conditionals (e.g.,ifeq) at the time it reads a Makefile.ref: https://stackoverflow.com/a/11994561/2514803