[syncd] Use steady clock for TimerWatchdog#613
Merged
yxieca merged 1 commit intosonic-net:masterfrom May 8, 2020
Merged
Conversation
Clock can rollback in big jumps and this causes TimerWatchdog to through and crashes syncd. This code uses steady clock instead. Steady clock is guaranteed to be monotonically increasing clock. signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Request for 201911 Branch
yxieca
approved these changes
May 8, 2020
yxieca
pushed a commit
that referenced
this pull request
May 8, 2020
Clock can rollback in big jumps and this causes TimerWatchdog to through and crashes syncd. This code uses steady clock instead. Steady clock is guaranteed to be monotonically increasing clock. signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
May 9, 2020
Clock can rollback in big jumps and this causes TimerWatchdog to through and crashes syncd. This code uses steady clock instead. Steady clock is guaranteed to be monotonically increasing clock. signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Contributor
|
@tahmed-dev Can you please create PR 201911. Cherry-pick has conflict |
tahmed-dev
added a commit
to tahmed-dev/sonic-sairedis
that referenced
this pull request
Jun 16, 2020
Clock can rollback in big jumps and this causes TimerWatchdog to through and crashes syncd. This code uses steady clock instead. Steady clock is guaranteed to be monotonically increasing clock. signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
added a commit
that referenced
this pull request
Jun 17, 2020
[syncd] Use steady clock for TimerWatchdog (#613)
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Clock can rollback in big jumps and this causes TimerWatchdog to through and crashes syncd. This code uses steady clock instead. Steady clock is guaranteed to be monotonically increasing clock. signed-of-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clock can rollback in big jumps and this causes TimerWatchdog to through
and crashes syncd. This code uses steady clock instead. Steady clock is
guaranteed to be monotonically increasing clock.
signed-of-by: Tamer Ahmed tamer.ahmed@microsoft.com