Skip to content

[trim]: Add Packet Trimming Drop Counters to VS lib#1630

Merged
tjchadaga merged 2 commits intosonic-net:masterfrom
nazariig:master-trim-counter
Aug 6, 2025
Merged

[trim]: Add Packet Trimming Drop Counters to VS lib#1630
tjchadaga merged 2 commits intosonic-net:masterfrom
nazariig:master-trim-counter

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

DEPENDS:

  1. [trim]: Add Packet Trimming Drop Counters DB schema sonic-swss-common#1055

HLD: sonic-net/SONiC#2033

Requires SAI API v1.16.2

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig force-pushed the master-trim-counter branch from cb8e123 to cbca4ba Compare July 24, 2025 15:46
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig force-pushed the master-trim-counter branch from c01d8c4 to 7e58fd9 Compare July 28, 2025 09:35
@nazariig nazariig marked this pull request as ready for review July 28, 2025 09:36
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Aug 4, 2025

@kcudnik can you please review?

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Aug 4, 2025

@kperumalbfn all comments are handled. Please sign-off

Copy link
Copy Markdown

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Aug 5, 2025

@kcudnik just a kind reminder

@nazariig nazariig requested review from prsunny and qiluo-msft August 5, 2025 12:39
@nazariig
Copy link
Copy Markdown
Collaborator Author

nazariig commented Aug 5, 2025

@r12f / @kperumalbfn FYI. This is a blocker for SWSS CI

@r12f
Copy link
Copy Markdown
Contributor

r12f commented Aug 6, 2025

Since Kumaresh is signed off, @tjchadaga is it ok to merge this PR now?

@kperumalbfn
Copy link
Copy Markdown

@qiluo-msft could you merge this PR

@tjchadaga tjchadaga merged commit d500ae7 into sonic-net:master Aug 6, 2025
15 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#77

@yejianquan
Copy link
Copy Markdown
Contributor

Remove 202505 request label since packet trimming feature won't be included into 202505 branch.

mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request Oct 23, 2025
### Summary: Add packet trimming counter testcase phase1

### Related PR
- Add packet trimming drop counter test plan
sonic-net/sonic-mgmt#19824
- Packet Trimming: Drop Counters HLD
sonic-net/SONiC#2033
- [trim]: Add Packet Trimming Drop Counters YANG model
sonic-net/sonic-buildimage#23422
- [trim]: Add Packet Trimming Drop Counters DB schema
sonic-net/sonic-swss-common#1055
- [trim]: Add Packet Trimming Drop Counters to VS lib
sonic-net/sonic-sairedis#1630
- [trim]: Add Packet Trimming Drop Counters to OA
sonic-net/sonic-swss#3777
- [trim]: Add Packet Trimming Drop Counters CLI
sonic-net/sonic-utilities#3993

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
mssonicbld added a commit to Azure/sonic-mgmt.msft that referenced this pull request Oct 23, 2025
### Summary: Add packet trimming counter testcase phase1

### Related PR
- Add packet trimming drop counter test plan
sonic-net/sonic-mgmt#19824
- Packet Trimming: Drop Counters HLD
sonic-net/SONiC#2033
- [trim]: Add Packet Trimming Drop Counters YANG model
sonic-net/sonic-buildimage#23422
- [trim]: Add Packet Trimming Drop Counters DB schema
sonic-net/sonic-swss-common#1055
- [trim]: Add Packet Trimming Drop Counters to VS lib
sonic-net/sonic-sairedis#1630
- [trim]: Add Packet Trimming Drop Counters to OA
sonic-net/sonic-swss#3777
- [trim]: Add Packet Trimming Drop Counters CLI
sonic-net/sonic-utilities#3993

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants