[configure.ac] implement SAI API version check#1000
Merged
kcudnik merged 4 commits intosonic-net:masterfrom May 17, 2022
Merged
[configure.ac] implement SAI API version check#1000kcudnik merged 4 commits intosonic-net:masterfrom
kcudnik merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
commented
Feb 10, 2022
| } | ||
| int main() { | ||
| sai_api_version_t version; | ||
| if (SAI_STATUS_SUCCESS != sai_query_api_version(&version)) |
Contributor
Author
There was a problem hiding this comment.
Also add a runtime check in syncd + log to syslog
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Collaborator
|
SAI module needs to be updated first to support sai version type |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
… include-sai-api-check
Collaborator
|
/azp run Azure.sonic-sairedis |
|
Commenter does not have sufficient privileges for PR 1000 in repo Azure/sonic-sairedis |
Collaborator
|
@kcudnik kindly remonder to review this PR now that 1.10.x is intergated into SONiC master |
kcudnik
approved these changes
May 14, 2022
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
#1034 is merged |
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Signed-off-by: Stepan Blyschak stepanb@nvidia.com The motivation for this change is described in the proposal sonic-net/SONiC#935 and proposal in SAI opencomputeproject/SAI#1404 NOTE: Requires to update SAI once opencomputeproject/SAI#1404 is in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
The motivation for this change is described in the proposal sonic-net/SONiC#935 and proposal in SAI opencomputeproject/SAI#1404
NOTE: Requires to update SAI once opencomputeproject/SAI#1404 is in.