[thermalctld] Fix issue: fan status should not be True when fan is absent#92
Merged
jleveque merged 1 commit intosonic-net:masterfrom Sep 15, 2020
Merged
Conversation
keboliu
approved these changes
Sep 15, 2020
liat-grozovik
approved these changes
Sep 15, 2020
jleveque
approved these changes
Sep 15, 2020
3 tasks
abdosi
pushed a commit
that referenced
this pull request
Sep 19, 2020
…sent (#92) If fan is not present, keep fan status value as "N/A".
This was referenced Sep 24, 2020
jleveque
pushed a commit
that referenced
this pull request
Sep 25, 2020
Previous PR #92 has been merged to 201911. The previous fix used a method FanStatus.is_ok, however, the implementation of this method is different between master and 201911. So we need an extra enhance for this issue. fan status should be true only if FanStatus.is_ok() and fan_status is true.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…f_2.0 (sonic-net#92) Small changes in 1.0 platform plugins psu_base.py and fan_base.py. Changes are related to PDDF 2.0 changes. psu_base.py: - psu_fan speed API name change - Changing the voltage, current and power units to fan_base.py: - Individual fans are counted instead of fantrays units - get_speed_rear() is not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did this?
Fan status displays OK when a fan is removed from system, the expect value should be "N/A"
How I did?
If fan is not present, keep fan status value as "N/A".