Fix test failures in test_thermalctld.py by passing arguments to ThermalControlDaemon()#700
Merged
judyjoseph merged 1 commit intosonic-net:masterfrom Oct 31, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 30, 2025
lotus-nexthop
approved these changes
Oct 31, 2025
lotus-nexthop
left a comment
There was a problem hiding this comment.
@judyjoseph please take a look, thanks!
Contributor
Author
The Azure pipelines on #635 ran and passed on Oct 1, which was before #652 got merged on Oct 28. The PR (#635) didn't raise any merge conflict, and we didn't sync master into it. So the failure was not caught. Thanks for the quick review of this PR! |
judyjoseph
approved these changes
Oct 31, 2025
vvolam
pushed a commit
to vvolam/sonic-platform-daemons
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix test failures in test_thermalctld.py, that was introduced in #652.
ThermalControlDaemon.__init__()now requires 3 arguments, so we have to pass them.Motivation and Context
Fixes #699, which will allow Azure Pipelines to pass.
test_get_chassis_exceptionandtest_get_chassis_successwere failing with the following error:because they didn't pass thermal-monitor-related args to
ThermalControlDaemon(), which were introduced in #635.How Has This Been Tested?
Ran unit tests locally and passed.
Additional Information (Optional)