Add pipeline check for missing __init__.py in sonic-xcvrd whl package#593
Merged
yxieca merged 2 commits intosonic-net:masterfrom Mar 17, 2025
Merged
Add pipeline check for missing __init__.py in sonic-xcvrd whl package#593yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@mihirpat1 verified the xcvrd wheel package now has the dom/utilities/vdm and dom/utilitites/db/
|
r12f
approved these changes
Mar 17, 2025
|
thanks Prince! this looks great! |
Contributor
|
@prgeor Thank you! |
mihirpat1
approved these changes
Mar 17, 2025
|
Removing 202412 tag, since it is already merged. |
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-daemons
that referenced
this pull request
Apr 22, 2025
…l package (sonic-net#593) Description Ensure that the pipeline fail to build if sonic-xcvrd whl package is missing init.py file. Motivation and Context The __init__.py file is necessary in each directory to indicate that the directory should be treated as a package. Tools like setuptools and find_packages() rely on the presence of __init__.py files to identify packages and subpackages. Without __init__.py files, the directories will not be included in the package distribution, leading to incomplete or broken packages. By ensuring that each directory contains an __init__.py file, we can create a complete and functional Python wheel package.
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-daemons
that referenced
this pull request
Apr 22, 2025
[202412] Add pipeline check for missing __init__.py in sonic-xcvrd whl package (sonic-net#593)
mihirpat1
pushed a commit
to mihirpat1/sonic-platform-daemons
that referenced
this pull request
May 6, 2025
…sonic-net#593) Description Ensure that the pipeline fail to build if sonic-xcvrd whl package is missing init.py file. Motivation and Context The __init__.py file is necessary in each directory to indicate that the directory should be treated as a package. Tools like setuptools and find_packages() rely on the presence of __init__.py files to identify packages and subpackages. Without __init__.py files, the directories will not be included in the package distribution, leading to incomplete or broken packages. By ensuring that each directory contains an __init__.py file, we can create a complete and functional Python wheel package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the pipeline fail to build if sonic-xcvrd whl package is missing init.py file.
Motivation and Context
__init__.pyfile is necessary in each directory to indicate that the directory should be treated as a package.setuptoolsandfind_packages()rely on the presence of__init__.pyfiles to identify packages and subpackages.__init__.pyfiles, the directories will not be included in the package distribution, leading to incomplete or broken packages.By ensuring that each directory contains an
__init__.pyfile, we can create a complete and functional Python wheel package.How Has This Been Tested?
Pipeline:- https://dev.azure.com/mssonic/build/_build/results?buildId=800459&view=logs&j=6f26e4aa-3eaf-5d24-2c84-463275687676&t=9d0df2c7-e5fa-5a6f-3817-988ca77cdfbe
Additional Information (Optional)