[MultiDB] should use multiDB API#57
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jun 5, 2020
Merged
Conversation
Contributor
Author
|
This PR and sonic-net/sonic-buildimage#4549 depends on each other. |
Contributor
Author
qiluo-msft
approved these changes
May 6, 2020
lguohan
reviewed
May 11, 2020
| sys.exit(LEDUTIL_LOAD_ERROR) | ||
|
|
||
| # Open a handle to the Application database | ||
| appl_db = daemon_base.db_connect(swsscommon.APPL_DB) |
Contributor
There was a problem hiding this comment.
why not use swsscommon.APPL_DB?
Contributor
Author
There was a problem hiding this comment.
swsscommon.APPL_DB is db id from swsscommon c++ library. Here we need a string "APPL_DB", For backward compatibility, we leave db id still there and not changed APPL_DB = "APPL_DB"
Contributor
Author
|
@qiluo-msft can we merge this first? then I'll update another PR "[MultiDB] daemon base should use multiDB DBConnector #4549" with this submodule update as well to avoid the dependency. |
lguohan
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com