Skip to content

Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands#475

Closed
JunhongMao wants to merge 2 commits intosonic-net:202205from
JunhongMao:202205
Closed

Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands#475
JunhongMao wants to merge 2 commits intosonic-net:202205from
JunhongMao:202205

Conversation

@JunhongMao
Copy link
Copy Markdown
Contributor

@JunhongMao JunhongMao commented Apr 23, 2024 •
edited
Loading

Why I did it

For the Nokia SONiC chassis procedures for insertion/hot swap of Switch Fabric Module(SFM),
the previous solution was using the below commands.

sudo nokia_cmd set shutdown-sfm <SFM-Num/Physical-Slot>

The below 4 PRs intend to add the below commands for the equivalent operations.
#475
sonic-net/sonic-utilities#3283
nokia/sonic-platform#6
sonic-net/sonic-buildimage#18938

sudo config chassis modules shutdown/startup <module name>

The HLD for Shutdown and Startup of the Fabric Module is below:
sonic-net/SONiC#1694

The below PR was replaced.
sonic-net/sonic-buildimage#18578

Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. When the cli command "sudo config chassis modules startup/shutdown" runs, it directly calls config/fabric_module_set_admin_status.py to do the related operations.

How to verify it

The below test was carried out on FABRIC-CARD3 module on the supervisor card.
1. Shutdown
sudo config chassis modules shutdown FABRIC-CARD3

2. Check the status to see if the FABRIC-CARD3 was down.
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3             Unavailable                4          Empty            down          N/A

sudo tail -f /var/log/syslog | grep "pmon#chassisd:"
May  1 00:07:54.192037 ixre-cpm-chassis15 WARNING pmon#chassisd: Module FABRIC-CARD3 went off-line!
 ...

 
3. Start up the module
sudo config chassis modules startup FABRIC-CARD3


4. Check the status
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3                    SFM4                4         Online              up  01214400362

sudo tail -f /var/log/syslog | grep "pmon#chassisd:"
May  1 00:26:29.501687 ixre-cpm-chassis15 NOTICE pmon#chassisd: Module FABRIC-CARD3 recovered on-line!


5. To test if the operation is still valid when the system reboot. For example, first shut down, 
then after saving config and reboot, the module should keep shutdown status. 
$ sudo config save
Existing files will be overwritten, continue? [y/N]: y

Then check the status to see if the FABRIC-CARD3 was down.
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3             Unavailable                4          Empty            down          N/A

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@JunhongMao
Update for the procedures for insertion/hot swap of Switch Fabric Mod…
1ed77d3 
…ule(SFM) by using "config chassis modules shutdown/startup" commands
This was referenced Apr 23, 2024
Merged
Closed
Merged
mlok-nokia
mlok-nokia reviewed Apr 23, 2024
View reviewed changes
mlok-nokia
mlok-nokia reviewed Apr 26, 2024
View reviewed changes
@abdosi
Copy link
Copy Markdown
Contributor

abdosi commented Apr 30, 2024

can we add Design doc as discussed in the Chassis Community meeting ?

@abdosi
Copy link
Copy Markdown
Contributor

abdosi commented Apr 30, 2024

@bmridul for review.

mlok-nokia
mlok-nokia approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mlok-nokia mlok-nokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@mlok-nokia
Copy link
Copy Markdown
Contributor

mlok-nokia commented May 2, 2024

@arlakshm @judyjoseph Please help to review this PR, tahnsk

@bmridul
Copy link
Copy Markdown
Collaborator

bmridul commented May 7, 2024

In Unit test, the operational status of Empty does not seem correct. The operational status could be "Offline" or some other word. However if the card has not been taken out of the chassis then it should not be Empty. Empty should indicate if the card has been physically removed from the chassis.

$ show chassis modules status
Name Description Physical-Slot Oper-Status Admin-Status Serial

...
FABRIC-CARD3 Unavailable 4 Empty down N/A

@JunhongMao
Copy link
Copy Markdown
Contributor Author

JunhongMao commented May 8, 2024

@mlok-nokia, please help to comment on this.

In Unit test, the operational status of Empty does not seem correct. The operational status could be "Offline" or some other word. However if the card has not been taken out of the chassis then it should not be Empty. Empty should indicate if the card has been physically removed from the chassis.

$ show chassis modules status Name Description Physical-Slot Oper-Status Admin-Status Serial

... FABRIC-CARD3 Unavailable 4 Empty down N/A

@mlok-nokia
Copy link
Copy Markdown
Contributor

mlok-nokia commented May 8, 2024

In Unit test, the operational status of Empty does not seem correct. The operational status could be "Offline" or some other word. However if the card has not been taken out of the chassis then it should not be Empty. Empty should indicate if the card has been physically removed from the chassis.

$ show chassis modules status Name Description Physical-Slot Oper-Status Admin-Status Serial

... FABRIC-CARD3 Unavailable 4 Empty down N/A

On nokia platform, When a SFM is power off, it cannot be detected even it is inserted in the chassis. Therefore, it is treated as empty instead of offline.

@mlok-nokia
Copy link
Copy Markdown
Contributor

mlok-nokia commented May 8, 2024

can we add Design doc as discussed in the Chassis Community meeting ?
HLD link:
sonic-net/SONiC#1694

judyjoseph
judyjoseph reviewed May 10, 2024
View reviewed changes
@mlok-nokia mlok-nokia mentioned this pull request May 10, 2024
Closed
11 tasks
@JunhongMao
Copy link
Copy Markdown
Contributor Author

JunhongMao commented May 17, 2024

@judyjoseph , please review it again and approve it for merging. Thanks.

judyjoseph
judyjoseph previously approved these changes May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunhongMao JunhongMao changed the base branch from 202205 to master May 28, 2024 21:01
@JunhongMao JunhongMao dismissed judyjoseph’s stale review May 28, 2024 21:01

The base branch was changed.

@JunhongMao JunhongMao changed the base branch from master to 202205 May 28, 2024 21:04
@JunhongMao JunhongMao mentioned this pull request May 29, 2024
Merged
10 tasks
@JunhongMao
Copy link
Copy Markdown
Contributor Author

JunhongMao commented May 29, 2024

This PR has been replaced by #491.
Because we should raise the PR first in master -- get it merged and later cherry-pick to 202205

@judyjoseph
Copy link
Copy Markdown
Contributor

judyjoseph commented May 29, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 29, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 5, 2024
Closed
Merged
@mlok-nokia
Copy link
Copy Markdown
Contributor

mlok-nokia commented Jun 12, 2024

@JunhongMao Please close this PR since it is no longer valid.

@JunhongMao JunhongMao closed this Jun 12, 2024
lotus-nexthop pushed a commit to lotus-nexthop/sonic-platform-daemons that referenced this pull request Oct 28, 2025
@vivekrnv
Fix the temperature parsing in nvme disks (sonic-net#475)
51c6207 
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlok-nokia mlok-nokia mlok-nokia approved these changes

@judyjoseph judyjoseph judyjoseph left review comments

Assignees

No one assigned

Labels

None yet

Projects

SONiC Chassis
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JunhongMao @abdosi @mlok-nokia @bmridul @judyjoseph