[201811 xcvrd] state machine enhancement#45
Merged
jleveque merged 3 commits intosonic-net:201811from Sep 16, 2019
keboliu:state_machine_change
Merged
[201811 xcvrd] state machine enhancement#45jleveque merged 3 commits intosonic-net:201811from keboliu:state_machine_change
jleveque merged 3 commits intosonic-net:201811from
keboliu:state_machine_change
Conversation
…l/unavalaible case
1. When receive system_fail event under NORMAL state, it will transmit to INIT instead of exit directly
2. In INIT state will handle system_fail event as the same as system_not_ready event,
try certain times, if system recovered then transmit to NORMAL state again, if not
covered in a certain period, then exit.
benifit of this change is that when system has error/failed temporarily, xcvrd can survive and recover,
instead of exit directly, make to more tolerence to errors.
jleveque
suggested changes
Sep 10, 2019
Collaborator
Author
|
@jleveque comments fixed, would you please have a look? |
stephenxs
approved these changes
Sep 16, 2019
jleveque
approved these changes
Sep 16, 2019
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 17, 2019
…3462) [201811 xcvrd] state machine enhancement sonic-net/sonic-platform-daemons#45
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport PR #44 from master to 201811 branch
Enhance the state machine in order to overcome a possible platform temporarily fail/unavailable case
if the system recovered then transmit to NORMAL state again, if not recovered in a certain period, then exit.
the benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover instead of exit directly, make to more tolerance to errors.