Skip to content

[201911][component]: Introduce new firmware management API#87

Merged
jleveque merged 1 commit intosonic-net:201911from
nazariig:201911-update-component-api
May 22, 2020
Merged

[201911][component]: Introduce new firmware management API#87
jleveque merged 1 commit intosonic-net:201911from
nazariig:201911-update-component-api

Conversation

@nazariig
Copy link
Copy Markdown
Collaborator

@nazariig nazariig commented May 21, 2020

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

Summary:
The purpose of this PR is to propagate some new component firmware management APIs which are intended to make the process more versatile. These new API's will be used mostly to extend fwutil functionality in order to support new platform components (e.g, SSD).

Motivation:

  1. Inform user in advance about required component firmware update actions when operating in manual mode
  2. Allow fwutil to read component firmware version directly from image instead of configuration file if not provided

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@jleveque
Copy link
Copy Markdown
Contributor

@nazariig: Should this be cherry-picked into 201911, also?

@nazariig
Copy link
Copy Markdown
Collaborator Author

@nazariig: Should this be cherry-picked into 201911, also?

@jleveque This PR is for 201911. For master it is already merged.
@abdosi asked to open the same PR to 201911.

@jleveque
Copy link
Copy Markdown
Contributor

@nazariig: Thanks. Somehow I swore I saw "master" as the target. :P

@jleveque jleveque changed the title [component]: Introduce new firmware management API [201911][component]: Introduce new firmware management API May 22, 2020
@jleveque jleveque merged commit ee60f54 into sonic-net:201911 May 22, 2020
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…onic-net#87)

* Updated based on sonic-swss-common changes to get the namespace (PR#378)
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-platform-common that referenced this pull request Jun 10, 2025
…nic-net#87)

<!-- Provide a general summary of your changes in the Title above -->

#### Description
`XcvrApiFactory.create_xcvr_api` may raise exception (e.g. the EEPROM is corrupted which has non unicode character). The exception would cause xcvrd crash. The PR is to catch the exception so that `XcvrApiFactory.create_xcvr_api` either return a None or a valid API object

#### Motivation and Context
When there is invalid character in module EEPROM, it would crash xcvrd and affect other healthy modules. The PR catches the exception in `XcvrApiFactory.create_xcvr_api` to prevent it affecting other modules.

#### How Has This Been Tested?
<!--
 Please describe in detail how you tested your changes.
 Include details of your testing environment, and the tests you ran to
 see how your change affects other areas of the code, etc.
-->
unit test
manual test

#### Additional Information (Optional)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants