[cmis] add a parameter to cmis.set_lpmode to ignore the time wait#564
Merged
prgeor merged 1 commit intosonic-net:masterfrom May 11, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
May 9, 2025
Collaborator
|
@prgeor kinldy reminder to provide your feedback on this PR |
prgeor
approved these changes
May 11, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-platform-common.msft#83 |
mssonicbld
added a commit
to mssonicbld/sonic-platform-daemons.msft
that referenced
this pull request
May 21, 2025
Depends on sonic-net/sonic-platform-common#564 <!-- Provide a general summary of your changes in the Title above --> #### Description Ignore time wait in `cmis.set_lpmode` #### Motivation and Context In `CmisManagerTask`, it calls `cmis.set_lpmode` for each logical port. The time wait causes a `wait_time * num_of_logical_port` delay in link up time. The PR is to optimize it. #### How Has This Been Tested? Manual test unit test #### Additional Information (Optional)
mssonicbld
added a commit
to Azure/sonic-platform-daemons.msft
that referenced
this pull request
May 21, 2025
Depends on sonic-net/sonic-platform-common#564 <!-- Provide a general summary of your changes in the Title above --> #### Description Ignore time wait in `cmis.set_lpmode` #### Motivation and Context In `CmisManagerTask`, it calls `cmis.set_lpmode` for each logical port. The time wait causes a `wait_time failure_prs.log skip_prs.log num_of_logical_port` delay in link up time. The PR is to optimize it. #### How Has This Been Tested? Manual test unit test #### Additional Information (Optional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a parameter to
cmis.set_lpmodeto allow user ignore the time waitMotivation and Context
In
CmisManagerTask, it callscmis.set_lpmodefor each logical port. The time wait causes await_time * num_of_logical_portdelay in link up time. The PR is to optimize it.How Has This Been Tested?
Additional Information (Optional)