Skip to content

Update Amphenol package for mock test#561

Merged
prgeor merged 1 commit intosonic-net:masterfrom
mihirpat1:update_amphenol_package
Apr 23, 2025
Merged

Update Amphenol package for mock test#561
prgeor merged 1 commit intosonic-net:masterfrom
mihirpat1:update_amphenol_package

Conversation

@mihirpat1
Copy link
Copy Markdown
Contributor

@mihirpat1 mihirpat1 commented Apr 23, 2025

Description

Add missing Amphenol package to support changes merged via #555

Motivation and Context

The current changeset is to fix the below traceback seen while building SONiC image

<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
/usr/lib/python3/dist-packages/_pytest/assertion/rewrite.py:168: in exec_module
    exec(co, module.__dict__)
tests/test_PsuChassisInfo.py:14: in <module>
    from .mock_platform import MockChassis, MockPsu, MockFanDrawer, MockModule
tests/mock_platform.py:1: in <module>
    from sonic_platform_base import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/__init__.py:1: in <module>
    from . import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/chassis_base.py:10: in <module>
    from . import sfp_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sfp_base.py:11: in <module>
    from .sonic_xcvr.xcvr_api_factory import XcvrApiFactory
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sonic_xcvr/xcvr_api_factory.py:22: in <module>
    from .api.amphenol.backplane import AmphBackplaneImpl
E   ModuleNotFoundError: No module named 'sonic_platform_base.sonic_xcvr.api.amphenol'

How Has This Been Tested?

Confirmed image build is successful and loaded image on DUT to confirm the fix to ensure that xcvrd is running without crashing.

Additional Information (Optional)

MSFT ADO - 32488018

@mihirpat1
Update Amphenol package for mock test
5f65c0c 
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mihirpat1 mihirpat1 requested a review from Copilot April 23, 2025 15:43
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 23, 2025

/azp run

Copilot AI reviewed Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the package dependencies in setup.py to include the Amphenol modules needed to fix a build error caused by missing module references.

  • Added the Amphenol API, codes, and mem_maps packages to the dependency list in setup.py.
  • Ensures compatibility with changes from the referenced sonic-platform-common pull request.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor prgeor merged commit c51c605 into sonic-net:master Apr 23, 2025
5 checks passed
@mssonicbld mssonicbld mentioned this pull request Apr 23, 2025
Merged
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 23, 2025

Cherry-pick PR to msft-202412: Azure/sonic-platform-common.msft#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@prgeor prgeor prgeor approved these changes

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Included in msft-202412 Branch Request for msft-202412 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mihirpat1 @mssonicbld @prgeor @r12f