Support for Custom Amphenol 800G Backplane catridge#555
Merged
prgeor merged 5 commits intosonic-net:masterfrom Apr 4, 2025
Merged
Support for Custom Amphenol 800G Backplane catridge#555prgeor merged 5 commits intosonic-net:masterfrom
prgeor merged 5 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
commented
Mar 31, 2025
| vendor_name = self._get_vendor_name() | ||
| vendor_pn = self._get_vendor_part_num() | ||
|
|
||
| # Mapping of IDs to their corresponding configurations |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reading custom EEPROM information from the Amphenol 800G Backplane cartridge by integrating new API, memory map, and code definitions along with associated test cases.
- Added new test cases for the AmphBackplaneImpl API
- Introduced AmphBackplaneMemMap, AmphBackplaneCodes, and AmphBackplaneImpl to handle backplane-specific behavior
- Updated the xcvr_api_factory and modified the public memmap and codes for consistency with the new backplane support
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/sonic_xcvr/test_xcvr_api_factory.py | Added tests for validating the new backplane API implementation |
| sonic_platform_base/sonic_xcvr/xcvr_eeprom.py | Minor code cleanup |
| sonic_platform_base/sonic_xcvr/xcvr_api_factory.py | Updated factory mapping to include the new AmphBackplaneImpl API |
| sonic_platform_base/sonic_xcvr/mem_maps/public/cmis.py | Introduced CmisFlatMemMap and adjusted CmisMemMap for clarity |
| sonic_platform_base/sonic_xcvr/mem_maps/amphenol/backplane.py | Added a custom memory map for Amphenol backplane with a potential super() call issue |
| sonic_platform_base/sonic_xcvr/fields/consts.py | Added a new constant for the cartridge slot ID (note potential misspelling) |
| sonic_platform_base/sonic_xcvr/codes/public/sff8024.py | Updated code definitions to include a backplane cartridge entry |
| sonic_platform_base/sonic_xcvr/codes/amphenol/backplane.py | Added new codes for the Amphenol backplane module |
| sonic_platform_base/sonic_xcvr/api/amphenol/backplane.py | Provided a custom API implementation for the backplane, also with a potential super() call issue |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@davidm-arista @bobbymcgonigle would you be able to review this PR please? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Apr 4, 2025
|
hi @prgeor , do you mind to help create a manual PR to bring this to 202412? |
|
hi @prgeor , gently ping on this one :D |
mssonicbld
added a commit
to mssonicbld/sonic-platform-common.msft
that referenced
this pull request
Apr 23, 2025
<!-- Provide a general summary of your changes in the Title above -->
#### Description
<!--
Describe your changes in detail
-->
Add missing Amphenol package to support changes merged via sonic-net/sonic-platform-common#555
#### Motivation and Context
<!--
Why is this change required? What problem does it solve?
If this pull request closes/resolves an open Issue, make sure you
include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
The current changeset is to fix the below traceback seen while building SONiC image
```
<frozen importlib._bootstrap>:690: in _load_unlocked
???
/usr/lib/python3/dist-packages/_pytest/assertion/rewrite.py:168: in exec_module
exec(co, module.__dict__)
tests/test_PsuChassisInfo.py:14: in <module>
from .mock_platform import MockChassis, MockPsu, MockFanDrawer, MockModule
tests/mock_platform.py:1: in <module>
from sonic_platform_base import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/__init__.py:1: in <module>
from . import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/chassis_base.py:10: in <module>
from . import sfp_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sfp_base.py:11: in <module>
from .sonic_xcvr.xcvr_api_factory import XcvrApiFactory
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sonic_xcvr/xcvr_api_factory.py:22: in <module>
from .api.amphenol.backplane import AmphBackplaneImpl
E ModuleNotFoundError: No module named 'sonic_platform_base.sonic_xcvr.api.amphenol'
```
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
Confirmed image build is successful and loaded image on DUT to confirm the fix to ensure that xcvrd is running without crashing.
#### Additional Information (Optional)
MSFT ADO - 32488018
r12f
added a commit
to Azure/sonic-platform-common.msft
that referenced
this pull request
Apr 23, 2025
<!-- Provide a general summary of your changes in the Title above -->
#### Description
<!--
Describe your changes in detail
-->
Add missing Amphenol package to support changes merged via sonic-net/sonic-platform-common#555
#### Motivation and Context
<!--
Why is this change required? What problem does it solve?
If this pull request closes/resolves an open Issue, make sure you
include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
The current changeset is to fix the below traceback seen while building SONiC image
```
<frozen importlib._bootstrap>:690: in _load_unlocked
???
/usr/lib/python3/dist-packages/_pytest/assertion/rewrite.py:168: in exec_module
exec(co, module.__dict__)
tests/test_PsuChassisInfo.py:14: in <module>
from .mock_platform import MockChassis, MockPsu, MockFanDrawer, MockModule
tests/mock_platform.py:1: in <module>
from sonic_platform_base import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/__init__.py:1: in <module>
from . import chassis_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/chassis_base.py:10: in <module>
from . import sfp_base
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sfp_base.py:11: in <module>
from .sonic_xcvr.xcvr_api_factory import XcvrApiFactory
/usr/local/lib/python3.11/dist-packages/sonic_platform_base/sonic_xcvr/xcvr_api_factory.py:22: in <module>
from .api.amphenol.backplane import AmphBackplaneImpl
E ModuleNotFoundError: No module named 'sonic_platform_base.sonic_xcvr.api.amphenol'
```
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
Confirmed image build is successful and loaded image on DUT to confirm the fix to ensure that xcvrd is running without crashing.
#### Additional Information (Optional)
MSFT ADO - 32488018
jianyuewu
pushed a commit
to jianyuewu/sonic-platform-common
that referenced
this pull request
May 7, 2025
* Support for Custom Amphenol 800G Backplane catridge * Address comment * Fix xcvrd crash * Fix the crash * Improve code coverage
jianyuewu
pushed a commit
to jianyuewu/sonic-platform-common
that referenced
this pull request
May 7, 2025
Support for Custom Amphenol 800G Backplane catridge (sonic-net#555)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for reading custom EEPROM of Amphenol 800G Backplane catridge
Motivation and Context
For custom application this catridge eeprom information parsing is required
How Has This Been Tested?
Tested on custom switch
Additional Information (Optional)