Skip to content

[sonic_ssd] Nokia-7215: Fix "show platform ssdhealth"#337

Merged
prgeor merged 1 commit intosonic-net:masterfrom
Pavan-Nokia:pavan_dev1
Mar 7, 2023
Merged

[sonic_ssd] Nokia-7215: Fix "show platform ssdhealth"#337
prgeor merged 1 commit intosonic-net:masterfrom
Pavan-Nokia:pavan_dev1

Conversation

@Pavan-Nokia
Copy link
Copy Markdown
Contributor

@Pavan-Nokia Pavan-Nokia commented Dec 15, 2022

Description:
The command is not showing the correct value for ssd health and temperature.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health : N/A
Temperature : N/A

Motivation and Context:
SSD health percentage and temperature not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command on Nokia-7215 and Unittests

Output after fix:
admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health : 100%
Temperature : 25C

@Pavan-Nokia
[sonic_ssd] Nokia-7215: Fix "show platform ssdhealth"
71e11bb 
Description:
The command is not showing the correct value for ssd health and temperature.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : N/A

Motivation and Context:
SSD health percentage and temperature not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command on Nokia-7215 and Unittests

Output after fix:
admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Dec 15, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Pavan-Nokia Pavan-Nokia marked this pull request as ready for review December 15, 2022 17:28
@prgeor prgeor added the SSD label Jan 12, 2023
@Blueve
Copy link
Copy Markdown

Blueve commented Jan 20, 2023

@prgeor can you help review this PR?

@StormLiangMS StormLiangMS requested a review from prgeor February 6, 2023 13:51
prgeor
prgeor requested changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for my review

@prgeor
Copy link
Copy Markdown
Collaborator

prgeor commented Mar 7, 2023

@Pavan-Nokia can you paste the output of smartctl -a /dev/sda

@prgeor prgeor merged commit c551a81 into sonic-net:master Mar 7, 2023
@prgeor
Copy link
Copy Markdown
Collaborator

prgeor commented Mar 7, 2023

@yxieca @StormLiangMS please help cherry pick as per the lables.

@Pavan-Nokia
Copy link
Copy Markdown
Contributor Author

Pavan-Nokia commented Mar 7, 2023 •
edited
Loading

@Pavan-Nokia can you paste the output of smartctl -a /dev/sda

root@sonic:~ smartctl -a /dev/sda
smartctl 7.2 2020-12-30 r5155 [armv7l-linux-5.10.0-18-2-armmp] (local build)
Copyright (C) 2002-20, Bruce Allen, Christian Franke, www.smartmontools.org
=== START OF INFORMATION SECTION ===
Device Model: M.2 (S42) 3IE4
Serial Number: YCA12206130220275
LU WWN Device Id: 5 24693e 000684700
Firmware Version: L20420i
User Capacity: 16,013,942,784 bytes [16.0 GB]
Sector Size: 512 bytes logical/physical
Rotation Rate: Solid State Device
TRIM Command: Available, deterministic, zeroed
Device is: Not in smartctl database [for details use: -P showall]
ATA Version is: ACS-3 T13/2161-D revision 4
SATA Version is: SATA 3.2, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is: Wed Mar 1 19:29:02 2023 UTC
SMART support is: Available - device has SMART capability.
SMART support is: Enabled
=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED
General SMART Values:
Offline data collection status: (0x02) Offline data collection activity
was completed without error.
Auto Offline Data Collection: Disabled.
Total time to complete Offline
data collection: ( 32) seconds.
Offline data collection
capabilities: (0x00) Offline data collection not supported.
SMART capabilities: (0x0002) Does not save SMART data before
entering power-saving mode.
Supports SMART auto save timer.
Error logging capability: (0x00) Error logging NOT supported.
General Purpose Logging supported.
SMART Attributes Data Structure revision number: 16
Vendor Specific SMART Attributes with Thresholds:
ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE
1 Raw_Read_Error_Rate 0x0000 000 000 000 Old_age Offline - 0
2 Throughput_Performance 0x0000 000 000 000 Old_age Offline - 0
5 Reallocated_Sector_Ct 0x0012 100 100 001 Old_age Always - 0
7 Unknown_SSD_Attribute 0x0000 000 000 000 Old_age Offline - 0
8 Unknown_SSD_Attribute 0x0000 000 000 000 Old_age Offline - 0
9 Power_On_Hours 0x0012 251 000 000 Old_age Always - 2043
10 Unknown_SSD_Attribute 0x0000 000 000 000 Old_age Offline - 0
12 Power_Cycle_Count 0x0012 015 000 000 Old_age Always - 15
163 Unknown_Attribute 0x0000 000 000 000 Old_age Offline - 10
168 Unknown_Attribute 0x0000 000 000 000 Old_age Offline - 0
169 Unknown_Attribute 0x0000 100 000 000 Old_age Offline - 100
175 Program_Fail_Count_Chip 0x0000 000 000 000 Old_age Offline - 0
192 Power-Off_Retract_Count 0x0012 002 000 000 Old_age Always - 2
194 Temperature_Celsius 0x0002 032 100 000 Old_age Always - 32 (3 34 0 30 0)
197 Current_Pending_Sector 0x0000 000 000 000 Old_age Offline - 0
225 Unknown_SSD_Attribute 0x0000 000 000 000 Old_age Offline - 0
240 Unknown_SSD_Attribute 0x0000 000 000 000 Old_age Offline - 0
165 Unknown_Attribute 0x0012 052 000 000 Old_age Always - 52
167 Unknown_Attribute 0x0012 025 000 000 Old_age Always - 25
170 Unknown_Attribute 0x0013 100 100 001 Pre-fail Always - 141
171 Unknown_Attribute 0x0012 000 100 000 Old_age Always - 0
172 Unknown_Attribute 0x0012 000 100 000 Old_age Always - 0
176 Erase_Fail_Count_Chip 0x0000 000 000 000 Old_age Offline - 0
184 End-to-End_Error 0x0012 000 000 000 Old_age Always - 0
187 Reported_Uncorrect 0x0012 000 000 000 Old_age Always - 0
229 Unknown_Attribute 0x0000 100 100 000 Old_age Offline - 89569723955864
232 Available_Reservd_Space 0x0013 000 000 000 Pre-fail Always - 0
235 Unknown_Attribute 0x0002 000 000 000 Old_age Always - 0
241 Total_LBAs_Written 0x0002 100 100 000 Old_age Always - 8662
242 Total_LBAs_Read 0x0002 100 100 000 Old_age Always - 7119
SMART Error Log not supported
SMART Self-test Log not supported
Selective Self-tests/Logging not supported
root@sonic:~#

AntonHryshchuk added a commit to AntonHryshchuk/sonic-buildimage that referenced this pull request Mar 8, 2023
@AntonHryshchuk
[submodule] Advance sonic-platform-common pointer
4f44b14 
Update sonic-platform-common submodule pointer to include the following:
* c551a81 [sonic_ssd] Nokia-7215: Fix show platform ssdhealth ([sonic-net#337](sonic-net/sonic-platform-common#337))
* 1929332 Fix pipeline apt-get purge error. ([sonic-net#349](sonic-net/sonic-platform-common#349))
* 3d57e0e [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD ([sonic-net#344](sonic-net/sonic-platform-common#344))

Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
yxieca pushed a commit that referenced this pull request Mar 8, 2023
@Pavan-Nokia @yxieca
[sonic_ssd] Nokia-7215: Fix "show platform ssdhealth" (#337)
c441bd7 
Description:
The command is not showing the correct value for ssd health and temperature.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : N/A

Motivation and Context:
SSD health percentage and temperature not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command on Nokia-7215 and Unittests

Output after fix:
admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
@Pavan-Nokia Pavan-Nokia deleted the pavan_dev1 branch March 9, 2023 18:16
StormLiangMS pushed a commit that referenced this pull request Mar 19, 2023
@Pavan-Nokia @StormLiangMS
[sonic_ssd] Nokia-7215: Fix "show platform ssdhealth" (#337)
8e631e3 
Description:
The command is not showing the correct value for ssd health and temperature.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : N/A

Motivation and Context:
SSD health percentage and temperature not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command on Nokia-7215 and Unittests

Output after fix:
admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blueve Blueve Blueve approved these changes

@prgeor prgeor prgeor approved these changes

Assignees

No one assigned

Labels

Included in 202205 Branch Request for 202205 Branch Request for 202211 Branch SSD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pavan-Nokia @Blueve @prgeor @yxieca