Conversation
|
This pull request introduces 2 alerts when merging 5e4f6e1 into 26c8346 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 35177c0 into 26c8346 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 068a4dd into 26c8346 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 854043d into 26c8346 - view on LGTM.com new alerts:
|
… and B are valid. 2. exception handling when vdm does not return prefec and postfec errors
|
This pull request introduces 1 alert when merging 520aefc into 26c8346 - view on LGTM.com new alerts:
|
@qinchuanares could you fix LGTM warning? |
It says in /sonic_platform_base/sonic_xcvr/api/public/cmis.py line 1024 sensitive data (password) is logged. But I am logging password_type, not really password. |
prgeor
left a comment
There was a problem hiding this comment.
@qinchuanares could you please address comments.
aravindmani-1
left a comment
There was a problem hiding this comment.
please check the comments
|
get_name() implementation is missing in SFP refactored where it is being used sonic-mgmt script. |
|
@qinchuanares please make sure sonic-mgt tests are passing |
I include get_name() function in CmisApi class. |
…ps\public\c_cmis.py to include mem_maps only associated with c-cmis 2. change cmd0001h() to module_enter_password(). 3. Enter password before start downloading (cmd0101h) regardless of module type and module vendor
|
This pull request introduces 3 alerts when merging 1dc4652 into 26c8346 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 20f6b72 into 26c8346 - view on LGTM.com new alerts:
|
get_name() is implemented per-platform and was not meant to be implemented in the new design as part of any XcvrApi-derived classes. |
…. removed get_name() function in cmis.py for now.
|
This pull request introduces 1 alert when merging add1040 into 26c8346 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging a93d90f into 26c8346 - view on LGTM.com new alerts:
|
prgeor
left a comment
There was a problem hiding this comment.
can you please address comments.
|
|
||
| return self.xcvr_eeprom.write(consts.TX_DISABLE_FIELD, channel_state) | ||
|
|
||
| def get_power_override(self): |
There was a problem hiding this comment.
can you add TODO, to remove this for CMIS as its not supported
There was a problem hiding this comment.
Do you need get_power_override() to be removed in this PR?
|
This pull request introduces 16 alerts when merging 0b9aaf9 into ef55364 - view on LGTM.com new alerts:
|
|
This pull request introduces 16 alerts when merging 2de0878 into ef55364 - view on LGTM.com new alerts:
|
|
This pull request introduces 16 alerts when merging 9989804 into ef55364 - view on LGTM.com new alerts:
|
|
This pull request introduces 8 alerts when merging 073b445 into ef55364 - view on LGTM.com new alerts:
|
…ade_feature() return type consistent
Description Clear all data from DB table when the daemon stops Motivation and Context Clean up when the daemon stops How Has This Been Tested? Check Thermal and physical info data if they are cleared after stopping the thermalctld.
This is a sfp-refactor follow-up work: to add 400ZR driver and high level functions into sfp-refactor. To query the keys in state_DB and write keys in config_DB into the module.
Description
The PR aims to provide 400ZR + SONiC support.
Motivation and Context
The motivation is to add 400ZR into the SONiC ecosystem. As we recently started to massively deploy 400ZR optical modules as replacement of InPhi DWDM ColorZ modules in metro links, there is emerging need to use SONiC routers to support 400ZR modules.
How Has This Been Tested?
In .\tests folder,
Additional Information (Optional)