Skip to content

Make eeprom_tlvinfo.py Python3 compatible#152

Merged
jleveque merged 1 commit intosonic-net:masterfrom
msosyak:tlvinfo_py3
Dec 4, 2020
Merged

Make eeprom_tlvinfo.py Python3 compatible#152
jleveque merged 1 commit intosonic-net:masterfrom
msosyak:tlvinfo_py3

Conversation

@msosyak
Copy link
Copy Markdown
Contributor

@msosyak msosyak commented Dec 4, 2020

Fix errors like below:

admin@sonic:~$ show version 

SONiC Software Version: SONiC.master.0-dirty-20201204.005739
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: 873fb969
Build date: Fri Dec  4 09:02:43 UTC 2020
Built by: user@sonic-build

Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara
ASIC: barefoot
Traceback (most recent call last):
  File "/usr/local/bin/decode-syseeprom", line 171, in <module>
    exit(main())
  File "/usr/local/bin/decode-syseeprom", line 47, in main
    t = class_('board', '','','')
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 113, in __init__
    if self.eeprom_init():
  File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 180, in eeprom_init
    self, "", [eeprom_params])
  File "/usr/local/lib/python3.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 178, in set_eeprom
    new_tlvs += new_tlv
TypeError: can't concat str to bytearray

@msosyak
Copy link
Copy Markdown
Contributor Author

msosyak commented Dec 4, 2020

@jleveque Please review

@jleveque jleveque merged commit fb05b3c into sonic-net:master Dec 4, 2020
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
sonic-net/sonic-buildimage#6768 change the kvm artifact name from kvm to vs

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants