Checkout specific gnmi_ext version to fix build error#44
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 25, 2020
Merged
Checkout specific gnmi_ext version to fix build error#44lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
|
Looks similar to the last break. Will there be more to handle for correct commit-id? |
lguohan
approved these changes
Mar 25, 2020
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 25, 2020
…4318) Module updated: sonic-mgmt-framework sonic-net/sonic-mgmt-framework#44
|
@renukamanavalan -- I think so. Eric checked and remarked: |
|
Thanks Jeff! The obvious next question, 'What is the plan for locking to the commit-id?'. |
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 26, 2020
…4318) Module updated: sonic-mgmt-framework sonic-net/sonic-mgmt-framework#44
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…onic-net#4318) Module updated: sonic-mgmt-framework sonic-net/sonic-mgmt-framework#44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix build error:
../../../gopkgs/src/github.com/openconfig/gnmi/proto/gnmi_ext/gnmi_ext.pb.go:47:11: undefined: "github.com/golang/protobuf/proto".ProtoPackageIsVersion4