[bgp-gr-helper] Add script for testing the BGP graceful restart helper function#996
Merged
liat-grozovik merged 6 commits intosonic-net:masterfrom Jul 21, 2019
wangxin:bgp-gr-helper
Merged
[bgp-gr-helper] Add script for testing the BGP graceful restart helper function#996liat-grozovik merged 6 commits intosonic-net:masterfrom wangxin:bgp-gr-helper
liat-grozovik merged 6 commits intosonic-net:masterfrom
wangxin:bgp-gr-helper
Conversation
added 2 commits
July 6, 2019 21:46
Add script for testing the BGP graceful restart helper function. Signed-off-by: Xin Wang <xinw@mellanox.com>
Collaborator
Author
|
@pavel-shirshov Added new comments addressing the review comments:
Script execution log is attached too. |
pavel-shirshov
suggested changes
Jul 18, 2019
Contributor
pavel-shirshov
left a comment
There was a problem hiding this comment.
Can you please address my comments?
Great work! Thanks!
* Add more comments * Organize the code to make the two test cases more obvious * Remove the uncessary configuration change of graceful-restart stalepath-time Signed-off-by: Xin Wang <xinw@mellanox.com>
Collaborator
Author
|
@pavel-shirshov Review comments addressed in the new commit. Could you please check? Thanks! |
Contributor
|
Hi All, I am getting following error given below while running the bgp_gr_helper test suite:- TASK [test : Get VM GR timer.] ************************************************* PLAY RECAP ********************************************************************* How to fix this issue? Thanks |
yxieca
pushed a commit
that referenced
this pull request
Jul 24, 2019
…r function (#996) * [bgp-gr-helper] Add bgp-gr-helper test case Add script for testing the BGP graceful restart helper function. Signed-off-by: Xin Wang <xinw@mellanox.com> * [bgp-gr-helper] Add supported topo t1-64-lag * [bgp-gr-helper] Improve the wording * Add checking IPv6 route * [bgp-gr-helper] Enable graceful restart for t1 topo * [bgp-gr-helper] Improve script structure * Add more comments * Organize the code to make the two test cases more obvious * Remove the uncessary configuration change of graceful-restart stalepath-time Signed-off-by: Xin Wang <xinw@mellanox.com>
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…r TH5 (sonic-net#996) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 - [x] 202412 ### Approach #### What is the motivation for this PR? xfail test_bgp_route_with_suppress vrf testing for TH5 as vrf support is still in developement #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Add script for testing the BGP graceful restart helper function.
Type of change
Approach
How did you do it?
Two scenarios are covered:
How did you verify/test it?
Tested on Mellanox platform
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
[t1, t1-lag, t1-64-lag]
Documentation
bgp-gr-helper.log