Skip to content

Add 't0-64-32' testbed_type for FibTest.#993

Merged
lguohan merged 1 commit intosonic-net:masterfrom
iris00522:fib_1
Jul 23, 2019
Merged

Add 't0-64-32' testbed_type for FibTest.#993
lguohan merged 1 commit intosonic-net:masterfrom
iris00522:fib_1

Conversation

@iris00522
Copy link
Copy Markdown
Contributor

Summary:
Fixes #966

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [+] Test case(new/improvement)

Approach

How did you do it?

Add 't0-64-32' testbed_type for FibTest.

How did you verify/test it?

Tested on the broadcom platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lguohan lguohan merged commit e7acfe8 into sonic-net:master Jul 23, 2019
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Mar 23, 2026
…nic-net#993)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

Currently this test we're running into this issue:
```
E 2026 Jan 31 04:37:53.222009 ERR systemd[1]: Failed to start core_uploader.service - Host core file uploader daemon.
```

This is because the core_uploader.service is restarted too quickly:

```
Feb 03 01:01:05 systemd[1]: core_uploader.service: Deactivated successfully.
Feb 03 01:01:05 systemd[1]: Stopped core_uploader.service - Host core file uploader daemon.
Feb 03 01:01:05 systemd[1]: Started core_uploader.service - Host core file uploader daemon.
Feb 03 01:01:06 systemd[1]: Stopping core_uploader.service - Host core file uploader daemon...
Feb 03 01:01:06 systemd[1]: core_uploader.service: Deactivated successfully.
Feb 03 01:01:06 systemd[1]: Stopped core_uploader.service - Host core file uploader daemon.
Feb 03 01:01:06 systemd[1]: core_uploader.service: Start request repeated too quickly.
Feb 03 01:01:06 systemd[1]: core_uploader.service: Failed with result 'start-limit-hit'.
Feb 03 01:01:06 systemd[1]: Failed to start core_uploader.service - Host core file uploader daemon.
```

During the step of

```
 syslog_server_tc1_replace(rand_selected_dut) # 4 restart
 syslog_server_tc1_remove(rand_selected_dut) # 3 restart
```

If `syslog_server_tc1_remove` starts right after `syslog_server_tc1_replace`, we would reach a threshold of limit 5 restart per 10 seconds. Therefore, systemd will kill the core_uploader service

```
admin@sonic:~$ systemctl show core_uploader.service -p StartLimitBurst -p StartLimitIntervalSec
StartLimitBurst=5
```
We should add a small sleep window here to avoid 5 restart within the same time window.

why `time.sleep(5)`? 4 restart would take 4 seconds, we sleep 5 to get to 9 seconds, reaching to `syslog_server_tc1_remove` would then take another few seconds until the restart kick in, we're safe for 10 second windows

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fib.j2] there is no testbed_type defined as 't0-64-32'

3 participants