Skip to content

Add 't0-64-32' and 't0-56' testbed_type for BcastTest.#991

Closed
iris00522 wants to merge 2 commits intosonic-net:masterfrom
iris00522:dir_bcast
Closed

Add 't0-64-32' and 't0-56' testbed_type for BcastTest.#991
iris00522 wants to merge 2 commits intosonic-net:masterfrom
iris00522:dir_bcast

Conversation

@iris00522
Copy link
Copy Markdown
Contributor

Description of PR

I get a fail message when we run the test item of dir_bcast.

[
"WARNING: No route found for IPv6 destination :: (no default route?)",
"dir_bcast_test.BcastTest ... ERROR",
"",
"======================================================================",
"ERROR: dir_bcast_test.BcastTest",
"----------------------------------------------------------------------",
"Traceback (most recent call last):",
" File "ptftests/dir_bcast_test.py", line 177, in runTest",
" self.check_all_dir_bcast()",
" File "ptftests/dir_bcast_test.py", line 86, in check_all_dir_bcast",
" self.check_ip_dir_bcast(bcast_ip, dst_port_list)",
" File "ptftests/dir_bcast_test.py", line 114, in check_ip_dir_bcast",
" src_port = random.choice([port for port in self.src_ports if port not in dst_port_list])",
"AttributeError: 'BcastTest' object has no attribute 'src_ports'",
"",
"----------------------------------------------------------------------",
"Ran 1 test in 0.007s",
"",
"FAILED (errors=1)"
]

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [+] Test case(new/improvement)

Approach

How did you do it?

Add 't0-64-32' and 't0-56' testbed_type for BcastTest.

How did you verify/test it?

Tested on the broadcom platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

@iris00522 iris00522 requested a review from a team as a code owner March 2, 2022 17:37
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update submodule sonic-sairedis that contains the following commit:

Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor (sonic-net#908) (sonic-net#991)
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Apr 3, 2026

This PR has been open since July 2019 (~7 years). The affected file (ansible/roles/test/files/ptftests/dir_bcast_test.py) is part of the legacy PTF test framework.

Additionally:

  1. Python 2-only syntaxrange(0, 2) + range(4, 18) concatenates lists in Python 2 but fails in Python 3 (where range returns an iterator). The repo has since moved to Python 3.
  2. Fragile pattern — Hardcoding port ranges per testbed type doesn't scale; port information should be derived from topology data.

Recommend closing this PR as stale.

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Apr 3, 2026

Closing this PR.

@wangxin wangxin closed this Apr 3, 2026
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
…#991)

This test validates distributed database synchronization that only
exists in multi-device VOQ chassis systems
There are existing tests to validate similar functionality on fixed
systems
- tests/platform_tests/test_interfaces.py
- tests/common/test_config_reload.py

---------

Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants