[mlnx] remove call to removed file disable_copp_rate_limiting.sh#960
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jun 25, 2019
Merged
Conversation
Change-Id: I29d8d7c892790e8383edf491bceb9ac9aa61ca06 Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
liat-grozovik
approved these changes
Jun 16, 2019
Collaborator
liat-grozovik
left a comment
There was a problem hiding this comment.
should u remove roles/test/files/mlnx/disable_copp_rate_limiting.sh?
Contributor
Author
|
@liat-grozovik There is no such file in public repository |
qiluo-msft
approved these changes
Jun 25, 2019
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
Cherry-pick sonic-net#21890 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to improve existing BGP tests to support BGP confederation. Below two tests are improved - [test_bgp_peer_shutdown.py](https://github.com/sonic-net/sonic-mgmt/compare/fix_bgp_confed_test?expand=1#diff-9d72d8d9e2fcf1b7573aadae84686354be322286dfce64199d0b158d8002cda0) - [test_bgp_update_timer.py](https://github.com/sonic-net/sonic-mgmt/compare/fix_bgp_confed_test?expand=1#diff-85d6c9d73bdee5ce2f7bca42ac67428028046115c26e6223a0df78e8706e3bd6) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? This PR is to improve existing BGP tests to support BGP confederation. #### How did you do it? 1. Improve [bgp.py](https://github.com/sonic-net/sonic-mgmt/compare/fix_bgp_confed_test?expand=1#diff-a6848e9239af6d197528a7960ad94553f237dc318bd195837d5a31a210ff879c) to support using `vtysh` to configure BGP neighbors 2. Improve [multi_asic.py](https://github.com/sonic-net/sonic-mgmt/compare/fix_bgp_confed_test?expand=1#diff-9b70276a3c2fb324d2737f57ab8ae139d7eb30cc886d3717f185088a9f8f241a) to add a helper function to retrieve BGP confederation ASN. #### How did you verify/test it? Both tests are verified on LT2/FT2 testbeds. ``` collected 2 items bgp/test_bgp_update_timer.py::test_bgp_update_timer_single_route[default] ^HPASSED [ 50%] bgp/test_bgp_update_timer.py::test_bgp_update_timer_session_down[default] PASSED [100%] collected 1 item bgp/test_bgp_peer_shutdown.py::test_bgp_peer_shutdown[default] ^HPASSED [100%] ``` #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I29d8d7c892790e8383edf491bceb9ac9aa61ca06
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation