Skip to content

Update CRM test to handle counters on different platforms#916

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
yvolynets-mlnx:crm_test_update
May 22, 2019
Merged

Update CRM test to handle counters on different platforms#916
liat-grozovik merged 1 commit intosonic-net:masterfrom
yvolynets-mlnx:crm_test_update

Conversation

@yvolynets-mlnx
Copy link
Copy Markdown
Contributor

Change-Id: If66887b1cd32104f9991be652ea836cbec9b2f48

Description of PR

Summary:
Fixes # (issue)
When memory/resources are shared, counters can be decremented/incremented not equally to 1. It can vary on different platforms.

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [+] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Executed and verified test run on several different devices.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Change-Id: If66887b1cd32104f9991be652ea836cbec9b2f48
@msftclas
Copy link
Copy Markdown

msftclas commented May 16, 2019

CLA assistant check
All CLA requirements met.

@liat-grozovik
Copy link
Copy Markdown
Collaborator

The test assumes that in some ASIC/Platform the take resource is not always 1. still the number of taken vise the number of available is calculated correct.
A discussion if this should be the ASIC/Platform behaviour is out of the scope of the test and should be discussed and clarify what should be the SAI behaviour in case more than one resource is taken per allocation.

@liat-grozovik liat-grozovik merged commit b013905 into sonic-net:master May 22, 2019
yxieca pushed a commit that referenced this pull request Sep 24, 2019
Change-Id: If66887b1cd32104f9991be652ea836cbec9b2f48
deerao02 pushed a commit to deerao02/sonic-mgmt that referenced this pull request Dec 18, 2025
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Submodule src/sonic-utilities 46b5aa8..5b73b83:
  > [intfutil] Fix error when <interface name> specified in show interface related commands (sonic-net#548)

Submodule src/sonic-swss a637562..93497ec:
  > [orchagent] PFC WD support for BFN platform (sonic-net#916)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants