[mtu] optimizing mtu for configurable in testbed#902
Merged
prsunny merged 2 commits intosonic-net:masterfrom May 8, 2019
Harrison-SH:daily-pr
Merged
[mtu] optimizing mtu for configurable in testbed#902prsunny merged 2 commits intosonic-net:masterfrom Harrison-SH:daily-pr
prsunny merged 2 commits intosonic-net:masterfrom
Harrison-SH:daily-pr
Conversation
prsunny
reviewed
May 6, 2019
ansible/roles/test/tasks/mtu.yml
Outdated
Contributor
There was a problem hiding this comment.
Can you pass this as test parameter if you want to make it configurable. This way, it seems user has to edit this value before running the test
Contributor
Author
There was a problem hiding this comment.
Agree. Done.
Two scenarios has been tested with the parameter of mtu and no the parameter.
passed.
prsunny
reviewed
May 8, 2019
ansible/roles/test/tasks/mtu.yml
Outdated
| - fail: msg="testbed_type {{testbed_type}} is invalid." | ||
| when: testbed_type not in ['t1-lag', 't1', 't1-64-lag'] | ||
|
|
||
| - set_fact: mtu=0 |
Contributor
There was a problem hiding this comment.
You can make this 9100 and remove the default from python script. Else it conveys the meaning that the test is run with mtu=0. What do you think?
Contributor
Author
There was a problem hiding this comment.
I think so. I also a little bit want to keep the main flow within py for the coming pytest.
Whether you mean just make it clear on this issue?
If so. I will do it.
Contributor
Author
There was a problem hiding this comment.
Agree. To make it clear.
Done and test passed.
prsunny
approved these changes
May 8, 2019
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jun 14, 2019
* [mtu] optimizing mtu for configurable in testbed * [mtu] optimizing mtu for configurable in testbed
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…nic-net#902) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: The test_trap_neighbor_miss not supported on non-TOR topologies, this PR updates the skip to run on t0 only. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Skip the COPP trap neighbor miss test on t1 topologies. #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) Improved route_check tool and adopt to 20191130 image. (sonic-net#898)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
I have added the parameter of "testbed_mtu", Users can use the default value or set their own mtu .
The parameter of self.pktlen has been added. When inputing parameter of "testbed_mtu" isn't the default of 0. It will be set with the value. otherwise. It will use the default value of DEFAULT_PACKET_LEN.
How did you verify/test it?
Any platform specific information?