Skip to content

[202012]Add a function to compare running config.#8880

Merged
yejianquan merged 1 commit intosonic-net:202012from
yutongzhang-microsoft:yutongzhang/compare_config_202012
Jul 10, 2023
Merged

[202012]Add a function to compare running config.#8880
yejianquan merged 1 commit intosonic-net:202012from
yutongzhang-microsoft:yutongzhang/compare_config_202012

Conversation

@yutongzhang-microsoft
Copy link
Copy Markdown
Contributor

Description of PR

There is a conflict when cherry pick PR (#8744) into 202012 branch, so raise this PR to cherry pick.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

There is a conflict when cherry pick PR (#8744) into 202012 branch, so raise this PR to cherry pick.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yutongzhang-microsoft yutongzhang-microsoft changed the title Add a function to compare running config. [202012]Add a function to compare running config. Jul 10, 2023
Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 1bb0112 into sonic-net:202012 Jul 10, 2023
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/compare_config_202012 branch July 10, 2023 03:03
yutongzhang-microsoft added a commit that referenced this pull request Jul 14, 2023
…heck` in 202012 branch. (#8980)

Description of PR
In 202012 branch, there is no multi-asic scenerio. But in PR (#8886) and (#8880), they innovate multi-asic scenerio in fixture core_dump_and_config_check. We think this innovation is unnecessary, so in this PR, we delete the code related to multi-asic scenerio.

What is the motivation for this PR?
In 202012 branch, there is no multi-asic scenerio. But in PR (#8886) and (#8880), they innovate multi-asic scenerio in fixture core_dump_and_config_check. We think this innovation is unnecessary, so in this PR, we delete the code related to multi-asic scenerio.

How did you do it?
Remove the code related to multi-asic scenerio in fixture core_dump_and_config_check.

Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants