Skip to content

Added a conditional skip by bug to vnet_vxlan test#8582

Merged
wangxin merged 1 commit intosonic-net:masterfrom
AharonMalkin:vnet_skip
Jun 14, 2023
Merged

Added a conditional skip by bug to vnet_vxlan test#8582
wangxin merged 1 commit intosonic-net:masterfrom
AharonMalkin:vnet_skip

Conversation

@AharonMalkin
Copy link
Copy Markdown
Contributor

@AharonMalkin AharonMalkin commented Jun 13, 2023

Description of PR

Added a conditional skip to vnet vxlan test due to bug #8374
Summary:
Set skip on mellanox basic on vnet vxlan test.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?

added a skip to test_mark_conditions.py

How did you verify/test it?

Ran the test with the skip and checked it's actually skipped.

Any platform specific information?

only on Mellanox platform.

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2023

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while constructing a mapping
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 4, column 1
found duplicate key "vxlan/test_vnet_vxlan.py" with value "{}" (original value: "{}")
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 1150, column 1

To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys

check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 13, 2023

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

while constructing a mapping
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 4, column 1
found duplicate key "vxlan/test_vnet_vxlan.py" with value "{}" (original value: "{}")
in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 1150, column 1

To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys

check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@AharonMalkin AharonMalkin force-pushed the vnet_skip branch 2 times, most recently from 6af1657 to 80b07cb Compare June 13, 2023 12:36
@wangxin wangxin merged commit fb0a34b into sonic-net:master Jun 14, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 10, 2023
@AharonMalkin @mssonicbld
Added a conditional skip by bug to vnet_vxlan test (sonic-net#8582)
68bfa13 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2023

Cherry-pick PR to 202205: #8863

@mssonicbld mssonicbld mentioned this pull request Jul 10, 2023
Merged
6 tasks
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 10, 2023
@AharonMalkin @mssonicbld
Added a conditional skip by bug to vnet_vxlan test (sonic-net#8582)
e832a74 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2023

Cherry-pick PR to 202012: #8864

@mssonicbld mssonicbld mentioned this pull request Jul 10, 2023
Merged
6 tasks
mssonicbld pushed a commit that referenced this pull request Jul 10, 2023
@AharonMalkin @mssonicbld
Added a conditional skip by bug to vnet_vxlan test (#8582)
854032c 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
mssonicbld pushed a commit that referenced this pull request Jul 10, 2023
@AharonMalkin @mssonicbld
Added a conditional skip by bug to vnet_vxlan test (#8582)
474d40e 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
@AharonMalkin @parmarkj
Added a conditional skip by bug to vnet_vxlan test (sonic-net#8582)
78765d3 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
AharonMalkin added a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
@AharonMalkin
Added a conditional skip by bug to vnet_vxlan test (sonic-net#8582)
971ca28 
What is the motivation for this PR?
Set skip by bug, as the test constantly fails due to improper route configuration

How did you do it?
added a skip to test_mark_conditions.py

How did you verify/test it?
Ran the test with the skip and checked it's actually skipped.

Any platform specific information?
only on Mellanox platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwjiang-ms xwjiang-ms xwjiang-ms approved these changes

Assignees

No one assigned

Labels

Approved for 202012 Branch Approved for 202205 branch Included in 202012 branch Included in 202205 branch Request for 202012 branch Request for 202205 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AharonMalkin @mssonicbld @xwjiang-ms @wangxin