Fix port alias mapping in minigraph_facts#830
Closed
wendani wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix port alias mapping in minigraph_facts#830wendani wants to merge 1 commit intosonic-net:masterfrom
wendani wants to merge 1 commit intosonic-net:masterfrom
Conversation
a7050-qx-32s Ethernet36 41,42,43,44 Ethernet14/1 14 40000 Ethernet124 5,6,7,8 Ethernet36 36 40000 Use port name Ethernet36's index as reference Signed-off-by: Wenda Ni <wenni@microsoft.com>
Contributor
|
I think we need to find a more fundamental fix. The root of the problem here is that this dictionary contains both port names and port aliases as keys, which is why any overlap can cause issues. This dictionary should only contain one or the other as keys. |
Contributor
|
agree with joe, it is not the right way to solve the problem. |
Contributor
|
Closing in favor of #832 |
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…s accounting test (sonic-net#830) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Added xfail to tacacs accounting test due to issue: [https://github.com/sonic-net/sonic-mgmt/issues/20452](https://github.com/sonic-net/sonic-mgmt/issues/20452) on Mellanox platforms ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Xfail failed test cases #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case that port alias conflicts with the port name, e.g., a7050-qx-32s
Ethernet36 41,42,43,44 Ethernet14/1 14 40000
Ethernet124 5,6,7,8 Ethernet36 36 40000
Use port name, e.g., Ethernet36's index, as the definitive reference
Signed-off-by: Wenda Ni wenni@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation