[fdb] Extend the FDB scripts to cover more MACs#813
Merged
liat-grozovik merged 3 commits intosonic-net:masterfrom Mar 18, 2019
wangxin:fdb-pr
Merged
[fdb] Extend the FDB scripts to cover more MACs#813liat-grozovik merged 3 commits intosonic-net:masterfrom wangxin:fdb-pr
liat-grozovik merged 3 commits intosonic-net:masterfrom
wangxin:fdb-pr
Conversation
added 3 commits
February 20, 2019 17:15
* Extend the FDB test case to cover more MAC entries. Populate L2 MAC table with 10 dummy MAC entries for each switch port during setup. Then send packet to each of the dummy MAC from other ports to verify L2 forwarding. * Remove the irrelevant ARP responding related code from ansible and the PTF script. * Clear FDB table before and after test. Signed-off-by: Xin Wang <xinw@mellanox.com>
* Change name of method check_route to more meaningful test_l2_forwarding * Remove unused import Signed-off-by: Xin Wang <xinw@mellanox.com>
* Count the number of MAC entries in output of "show mac". Compare with the expected number of entries, including dummy MACs and all MACs Signed-off-by: Xin Wang <xinw@mellanox.com>
Collaborator
|
@wangxin can you please elaborate what is the max scale of the FDB after the change? whether there are additional flows which are validated by the new test |
Collaborator
Author
|
On t0 topology:
|
liat-grozovik
approved these changes
Mar 13, 2019
qiluo-msft
reviewed
Mar 13, 2019
| self.setUpFdb() | ||
|
|
||
| self.log("Start arp_responder") | ||
| self.shell(["supervisorctl", "start", "arp_responder"]) |
Contributor
There was a problem hiding this comment.
arp_responder [](start = 47, length = 13)
why the supervisorctl is removed? #Closed
Collaborator
Author
There was a problem hiding this comment.
This code is to start arp_responder on the PTF container. Arp_responder is to reply to ARP request. It was not used in this FDB testing at all. So I removed irrelevant code.
qiluo-msft
approved these changes
Mar 18, 2019
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
1906fdf [pyext] Update Makefile to disable warning Wconversion for older swig (sonic-net#817) 1dbcaeb Remove gbsyncd_startup.py (sonic-net#813) 0372615 [vslib] Refresh queue pause status (sonic-net#814) 00d883c [sairedis] Add sai_dbg_generate_dump api to redis interface (sonic-net#811) 8585803 [sairedis] Unlock api mutex for communication mode (sonic-net#812) c69549a [pyext] Add SWIG sairedis python submodule (sonic-net#806)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The existing FDB scripts only send one packet on each PTF interface to populate MAC table on DUT. This update extends the FDB scripts to send 10 more packets from each PTF interface to DUT to populate MAC table with more entries. Each packet has an unique dummy MAC address. Then send packets from each PTF ports to remaining ports to verify that L2 forwarding works for these MAC addresses.
Type of change
Approach
How did you do it?
How did you verify/test it?
Tested on Mellanox platform using the latest master image.
Any platform specific information?
None
Supported testbed topology if it's a new test case?
Supported topologies are not changed: [t0, t0-16, t0-64, t0-64-32, t0-116]
Documentation