[pre-commit] Fix style issues in test scripts under tests/p* folder#7968
Merged
xwjiang-ms merged 3 commits intosonic-net:masterfrom Apr 10, 2023
Merged
[pre-commit] Fix style issues in test scripts under tests/p* folder#7968xwjiang-ms merged 3 commits intosonic-net:masterfrom
tests/p* folder#7968xwjiang-ms merged 3 commits intosonic-net:masterfrom
Conversation
What is the motivation for this PR? pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional. To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit. How did you do it? This change fixes the style issues of test scripts under `tests/p*` folder How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
wangxin
previously approved these changes
Apr 6, 2023
Collaborator
|
@xwjiang-ms Can you rebase to resolve the merge conflicts? |
… pre-commit-tests-p resolve conflicts
wangxin
previously approved these changes
Apr 7, 2023
… pre-commit-tests-p Fix merge conflict
wangxin
approved these changes
Apr 10, 2023
This was referenced Apr 20, 2023
wsycqyz
added a commit
that referenced
this pull request
Apr 25, 2023
Fixes test failure in test_cont_link_flap.py caused by #7968 What is the motivation for this PR? Test failed with error: File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory) ValueError: could not convert string to float: '\1' How did you do it? Correct reg express. How did you verify/test it? Manually run test case: test_cont_link_flap.py
6 tasks
ZhaohuiS
added a commit
that referenced
this pull request
Apr 25, 2023
What is the motivation for this PR? #7968 remove import * for test_platform_info.py. mocker_factory, disable_thermal_policy fixtures can't be found. How did you do it? import them and add # noqa F401 and # noqa F811 to ignore pre-commit error. How did you verify/test it? run test_platform_info.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
slutati1536
pushed a commit
to slutati1536/sonic-mgmt
that referenced
this pull request
May 11, 2023
…sonic-net#7968) What is the motivation for this PR? pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional. To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit. How did you do it? This change fixes the style issues of test scripts under `tests/p*` folder How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
slutati1536
pushed a commit
to slutati1536/sonic-mgmt
that referenced
this pull request
May 11, 2023
…sonic-net#7968) What is the motivation for this PR? pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional. To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit. How did you do it? This change fixes the style issues of test scripts under `tests/p*` folder How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
Fixes test failure in test_cont_link_flap.py caused by sonic-net#7968 What is the motivation for this PR? Test failed with error: File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory) ValueError: could not convert string to float: '\1' How did you do it? Correct reg express. How did you verify/test it? Manually run test case: test_cont_link_flap.py
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
What is the motivation for this PR? sonic-net#7968 remove import * for test_platform_info.py. mocker_factory, disable_thermal_policy fixtures can't be found. How did you do it? import them and add # noqa F401 and # noqa F811 to ignore pre-commit error. How did you verify/test it? run test_platform_info.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Fixes test failure in test_cont_link_flap.py caused by sonic-net#7968 What is the motivation for this PR? Test failed with error: File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory) ValueError: could not convert string to float: '\1' How did you do it? Correct reg express. How did you verify/test it? Manually run test case: test_cont_link_flap.py
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? sonic-net#7968 remove import * for test_platform_info.py. mocker_factory, disable_thermal_policy fixtures can't be found. How did you do it? import them and add # noqa F401 and # noqa F811 to ignore pre-commit error. How did you verify/test it? run test_platform_info.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional.
To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit.
How did you do it?
This change fixes the style issues of test scripts under
tests/p*folderHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation