Skip to content

[warm/fast reboot] fix warm reboot test issue and update bgp graceful restart timeout#790

Merged
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:wbtest
Jan 26, 2019
Merged

[warm/fast reboot] fix warm reboot test issue and update bgp graceful restart timeout#790
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:wbtest

Conversation

@yxieca
Copy link
Copy Markdown
Collaborator

@yxieca yxieca commented Jan 26, 2019

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

  • Fix syntax error when warm reboot test observed no data plane disruption.
  • Update BGP graceful restart timeout default value to match SONiC default.

How did you verify/test it?

  • warm reboot test
  • fast reboot test

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This value matches SONiC default value.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca merged commit 1b81d6b into sonic-net:master Jan 26, 2019
@yxieca yxieca deleted the wbtest branch January 26, 2019 02:48
deerao02 pushed a commit to deerao02/sonic-mgmt that referenced this pull request Dec 18, 2025
Remove unused parameters in remove_topo.yml

The parameters added in
Azure/sonic-mgmt.msft#743

When previously removed in
Azure/sonic-mgmt.msft#622


Without this change we have the next error:
```fatal: [*****]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'duts_midplane_ports' is undefined\n\nThe error appears to be in '...../sonic-mgmt/ansible/roles/vm_set/tasks/remove_topo.yml'```

Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Submodule src/sonic-swss 57e531d..0e5c1ff:
  > Adopt to signature change of Selectable::readData, which switched (sonic-net#1061)
  > [orchagent]: Remove try/catch for correct coredump file (sonic-net#790)

Submodule src/sonic-swss-common d7b1f53..ece5ce4:
  > timerfd fix: Pass false alarm to caller. (sonic-net#307)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants