Skip to content

Walk around for code scanning hanging issue.#7752

Merged
liushilongbuaa merged 3 commits intosonic-net:masterfrom
liushilongbuaa:test-1
Mar 16, 2023
Merged

Walk around for code scanning hanging issue.#7752
liushilongbuaa merged 3 commits intosonic-net:masterfrom
liushilongbuaa:test-1

Conversation

@liushilongbuaa
Copy link
Copy Markdown
Contributor

@liushilongbuaa liushilongbuaa commented Mar 15, 2023

Description of PR

Summary:
code scanning query 'py/polynomial-redos' hangs for unknown reason.
This PRs' codeql will not pass. After it is merged, code scanning will pass.

Issue on codeql: github/codeql#12528

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/codeql-analysis.yml

check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@liushilongbuaa liushilongbuaa changed the title Test 1 Fix code scanning hanging issue. Mar 15, 2023
@liushilongbuaa liushilongbuaa changed the title Fix code scanning hanging issue. Walk around for code scanning hanging issue. Mar 15, 2023
@liushilongbuaa liushilongbuaa marked this pull request as ready for review March 15, 2023 09:17
@liushilongbuaa liushilongbuaa merged commit f4fc9d1 into sonic-net:master Mar 16, 2023
wangxin pushed a commit that referenced this pull request Mar 24, 2023
wangxin pushed a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants