Fix Cisco-8000 platform file writing#7669
Conversation
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
| original_values = {} | ||
| markings_dict = {} | ||
| # Getting markings from first device. | ||
| device = json_contents['devices'][0] |
There was a problem hiding this comment.
Is it guaranteed that json_contents['devices'] will have only one entry ?
There was a problem hiding this comment.
In non-T2 asics, it should have only 1.
If it has more than one, they should all be in sync, and it's only necessary to return the first.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix Cisco-8000 platform file writing.
How did you do it?
Platform file variable location moved into a deeper structure, added relevant accessor to change these variables.
How did you verify/test it?
Reproduced breakage on 202012 branch for LossyQueueVoq test case, verified this change passes the test.
Uplifted 202012 edited code to master to file this PR since master/202205 also needs the change.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation