Add portchannel interface changing event count in test#758
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Dec 12, 2018
Merged
Add portchannel interface changing event count in test#758qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Sample output ``` 2018-12-10 19:33:31 : LACP/BGP were down for (extracted from cli): 2018-12-10 19:33:31 : -------------------------------------------------- 2018-12-10 19:33:31 : 10.10.247.196 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0) ``` Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
pavel-shirshov
suggested changes
Dec 11, 2018
| self.wait_until_vlan_cpu_port_down() | ||
| self.cancel_timeout() | ||
| try: | ||
| self.log("Schedule to reboot the remote switch in %s sec" % self.reboot_delay) |
Contributor
There was a problem hiding this comment.
why do we need try block here? #Resolved
Contributor
Author
There was a problem hiding this comment.
It cover many cases. One is:
- 'warm-reboot' may fail, and it will throw a KeyboardInterrupt exception
- try block catch it and come into final block
Another one is interrupt a long running (or infinite loop) test, we still get some meaningful log output.
In reply to: 240769373 [](ancestors = 240769373)
|
|
||
| return is_down_count, sum(res[False]) # summary_downtime | ||
|
|
||
| def check_change_time(self, output, entity, what): |
Contributor
There was a problem hiding this comment.
I'd suggest to rename what to more meaningful name #Resolved
Contributor
Author
There was a problem hiding this comment.
How about check_event_count? Or do you prefer else?
In reply to: 240769593 [](ancestors = 240769593)
Contributor
Author
There was a problem hiding this comment.
pavel-shirshov
approved these changes
Dec 11, 2018
yxieca
approved these changes
Dec 12, 2018
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities ae274e5..8237848: > [fast/warm reboot] ignore errors after shutting down critical service(s) (sonic-net#761) > [neighbor advertiser] raise exception when http endpoint return failure (sonic-net#758) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample output
BTW, the underlying command I am using