fix the get_auto_negotiation_mode#7267
Merged
arlakshm merged 1 commit intosonic-net:masterfrom Jan 19, 2023
Merged
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Contributor
|
LGTM.. however what is the best way to get auto-neg capability for eos that does not support json o/p ? |
Contributor
Author
|
Contributor
|
@arlakshm the original command test use to retrieve autoneg state is |
abdosi
approved these changes
Jan 18, 2023
wangxin
pushed a commit
that referenced
this pull request
Jan 30, 2023
Description of PR Summary: Fixes #7266 Type of change [ x] Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 201911 202012 [x ] 202205 Approach What is the motivation for this PR? In some eos fanout switches the show interface status <portname> json is not supported. This causes error in test_update_testbed_metadata How did you do it? in get_auto_negotiation_mode return None instead of raising a error How did you verify/test it? Run pretest in t2 testbed Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
Description of PR
Summary:
Fixes #7266
Type of change
Back port request
Approach
What is the motivation for this PR?
In some eos fanout switches the
show interface status <portname> jsonis not supported. This causes error intest_update_testbed_metadataHow did you do it?
in
get_auto_negotiation_modereturn None instead of raising a errorHow did you verify/test it?
Run pretest in t2 testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation