Skip to content

[Mellanox] Add minimal table definition for SN2201#6943

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
keboliu:sn2201-minimal-table
Dec 6, 2022
Merged

[Mellanox] Add minimal table definition for SN2201#6943
liat-grozovik merged 1 commit intosonic-net:masterfrom
keboliu:sn2201-minimal-table

Conversation

@keboliu
Copy link
Copy Markdown
Contributor

@keboliu keboliu commented Dec 1, 2022 •
edited by liat-grozovik
Loading

Signed-off-by: Kebo Liu kebol@nvidia.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

SN2201 have minimal table defined in PR sonic-net/sonic-buildimage#12602
test case also need to be updated.

How did you do it?

Add minitable definition for SN2201

How did you verify/test it?

run test platform_tests/mellanox/test_thermal_control.py::test_dynamic_minimum_table

Any platform specific information?

Mellanox only

Supported testbed topology if it's a new test case?

Documentation

@keboliu
add minimal table definition for SN2201
448b718 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 1, 2022

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/mellanox/minimum_table.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/mellanox/minimum_table.py:3:34: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:3:46: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:3:49: E203 whitespace before ','
tests/platform_tests/mellanox/minimum_table.py:3:60: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:4:34: E231 missing whitespace after ':'
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 2, 2022

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/mellanox/minimum_table.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@keboliu keboliu force-pushed the sn2201-minimal-table branch from 561345c to bcf5f12 Compare December 2, 2022 07:38
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 2, 2022

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/mellanox/minimum_table.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@keboliu keboliu force-pushed the sn2201-minimal-table branch from bcf5f12 to 448b718 Compare December 2, 2022 07:41
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 2, 2022

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/mellanox/minimum_table.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/mellanox/minimum_table.py:3:34: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:3:46: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:3:49: E203 whitespace before ','
tests/platform_tests/mellanox/minimum_table.py:3:60: E231 missing whitespace after ':'
tests/platform_tests/mellanox/minimum_table.py:4:34: E231 missing whitespace after ':'
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@keboliu
Copy link
Copy Markdown
Contributor Author

keboliu commented Dec 6, 2022

pre-commit checker failure is not relevant to the new change.

@liat-grozovik liat-grozovik merged commit 4b7fe72 into sonic-net:master Dec 6, 2022
@keboliu keboliu deleted the sn2201-minimal-table branch December 7, 2022 05:55
wangxin pushed a commit that referenced this pull request Dec 7, 2022
@keboliu @wangxin
[Mellanox] Add minimal table definition for SN2201 (#6943)
cc9dcec 
SN2201 have minimal table defined in PR sonic-net/sonic-buildimage#12602
test case also need to be updated.

- How did you do it?
Add minitable definition for SN2201

- How did you verify/test it?
run test platform_tests/mellanox/test_thermal_control.py::test_dynamic_minimum_table

- Any platform specific information?
Mellanox only

Signed-off-by: Kebo Liu <kebol@nvidia.com>
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Jul 27, 2023
@yaqiangz @Blueve
Merged PR 1410: Merge branch '202205' of https://github.com/Azure/son…
75cb740 
…ic-mgmt into internal-202205

Fix merge conflicts.
- [pre-commit] Fix style issues in test scripts under `tests/acl` folder (sonic-net#6679)
- Moving check for reboot cause after interface status check (sonic-net#6721)
- Adding watchdog timeout values for Cisco 8808 Supervisor and Different LCs (sonic-net#6776)
- add Ether check in macsec_dp_poll (sonic-net#6828)
- Disable PFC watchdog in test_cpu_memory_usage_counterpoll (sonic-net#6851)
- Testcase to verify that lossless traffic is not dropped during congesion. (sonic-net#6853)
- Ignore Broadcom sai sai unbind ERR log for now (sonic-net#6539)
- [chassis][multi-asic] update the loganalyser regex for multi asic (sonic-net#6885)
- [mx] Fix test_acl failed on mx topo (sonic-net#6971) (sonic-net#6983)
- [202205][mx] Add support for mx in test_null_route_helper (sonic-net#6967) (sonic-net#6982)
- [m0][everflow] Add m0 support for everflow and refactor everflow setup_info (sonic-net#6900)
- [ACL] Add acl stress test (sonic-net#6903)
- Enhance test_tor_ecn (sonic-net#6906)
- Fix erros - Added unique IPV6 address for the missed ACL rules PR sonic-net#6390 (sonic-net#6909)
- enabled bfd tests (sonic-net#6919)
- Skip bgp speaker test on backend topo (sonic-net#6922)
- [advanced-reboot] Handle logs in tmpfs: backup two log files before reboot (sonic-net#6923)
- Fix missing definition (sonic-net#6930)
- [Mellanox] Add minimal table definition for SN2201 (sonic-net#6943)
- Update qos test param for dualtor topology (sonic-net#6948)
- fix setup for single asic lc (sonic-net#6951)
- Fix QoS sai test for running with python3 (sonic-net#6961)
- Don't fail if logrotate cron job file isn't present (sonic-net#6964)
- Disable post sanity check for vxlan test (sonic-net#6980)
- Merge branch 'azure-202205' into dev/yaqiangzhu/202205_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@Junchao-Mellanox Junchao-Mellanox Awaiting requested review from Junchao-Mellanox

Assignees

No one assigned

Labels

Included in 202205 branch Request for 202205 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keboliu @liat-grozovik @wangxin