Add support of Barefoot asic to everflow test#688
Merged
lguohan merged 3 commits intosonic-net:masterfrom Sep 1, 2018
johcheun:master
Merged
Add support of Barefoot asic to everflow test#688lguohan merged 3 commits intosonic-net:masterfrom johcheun:master
lguohan merged 3 commits intosonic-net:masterfrom
johcheun:master
Conversation
|
|
stcheng
previously requested changes
Aug 29, 2018
Contributor
stcheng
left a comment
There was a problem hiding this comment.
Could you eliminate the sensors test code changes from the EVERFLOW test code changes?
Contributor
Author
|
Ok, I will backout the sensors change and raise a separate PR afterward. |
…ase" This reverts commit f67f2aa.
Contributor
|
Thanks because the sensors test is pending on the changes of the buildimage change, it is better to have it separated from the mirror test. |
lguohan
approved these changes
Sep 1, 2018
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
…onic-net#688) ### Description of PR Summary: Skip the everflow_dscp_with_policer test for the TH4 and TH5 Broadcom ASICs, as Policer is not supported for MIRROR_SESSION on those ASICs. Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202412 - [x] 202505 ### Approach #### What is the motivation for this PR? Mirror policing is not supported on Broadcom TH4/TH5 ASICs, so test_everflow_dscp_with_policer should be skipped accordingly. #### How did you do it? Added th4 and th5 to the list of unsupported ASICs for mirror policing. #### How did you verify/test it? Attempted to run the test and confirmed it is skipped. Note: test log shows: "Skipping test since mirror policing is not supported on broadcom th5 platforms" #### Any platform specific information? TH4/TH5-based platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Type of change
Approach
How did you do it?
Added check for asic_type, and only strip first 12 bytes of erspan header before checking for the payload
How did you verify/test it?
Ran everflow testcase by name
Any platform specific information?
montara and mavericks platforms for Barefoot asic
Supported testbed topology if it's a new test case?
Documentation