Merged
Conversation
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
ADO: 34701862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
After trying to optimize performance of extract_log module I broke the module's functionality:
filenames in combine_logs_and_save function are the files to copy for log analysis. Finding start line in ordered filenames list caused only the last file to copy. Now, it starts from the last and copies all the rest files as well.
How did you verify/test it?
Simulated a lot of logs to achive situation where start marker and end marker are in seperate log files and run CRM test which uses loganalyzer.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation