[snmp] extend snmp test for xcvrd#677
[snmp] extend snmp test for xcvrd#677lguohan merged 2 commits intosonic-net:masterfrom keboliu:xcvrd-snmp-test
Conversation
|
|
||
| - name: Check all transceivers present in Entity MIB | ||
| fail: | ||
| msg: '{{ (((item.value.name.split("Ethernet")[-1] | int + 1) * 1000) | string) }}' |
There was a problem hiding this comment.
Could you explain the complex expression?
There was a problem hiding this comment.
@qiluo-msft the OID index is defined as ifindex*1000, and for EthernetN, ifindex is (N+1), so the OID index for EthernetN will be (N +1)*1000, detail info can be found in the requirement https://github.com/Azure/SONiC/blob/gh-pages/doc/OIDsforSensorandTransciver.MD#transceiver-requirements-entity-mib
There was a problem hiding this comment.
The comment is perfect for code comment. Every future code reader will have the same question.
There was a problem hiding this comment.
@qiluo-msft will add this to code as comments.
There was a problem hiding this comment.
@qiluo-msft comments added to the code, let me know if you have further comments.
|
It will break the nightly test of old images. Could you add some logic to bypass the test? |
This reverts commit 3e53ee8.
This test is failing since extra timeout settings are causing pfcwd state to change in the meantime and test fails. extended timeout setting should be applicable for xgs only and not dnx platforms.
…D automatically (#23929) #### Why I did it src/sonic-platform-daemons ``` * f661d74 - (HEAD -> 202505, origin/202505) pulling into 202505 (sonic-net#677) (35 minutes ago) [Gregory Boudreau] ``` #### How I did it #### How to verify it #### Description for the changelog
Description of PR
Summary:
Extend snmp test case to support xcvrd snmp test
Type of change
Approach
How did you do it?
Add new test cases in snmp test to test xcvrd feature
detail see test plan https://github.com/Azure/SONiC/blob/gh-pages/doc/xcvrd-snmp-testbed-test-plan.md
How did you verify/test it?
run test on mlnx platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Test plan link: https://github.com/Azure/SONiC/blob/gh-pages/doc/xcvrd-snmp-testbed-test-plan.md