fix arptest fail if using ptf-docker created by t1-64-lag#670
Merged
maggiemsft merged 2 commits intosonic-net:masterfrom Aug 15, 2018
Merged
fix arptest fail if using ptf-docker created by t1-64-lag#670maggiemsft merged 2 commits intosonic-net:masterfrom
maggiemsft merged 2 commits intosonic-net:masterfrom
Conversation
prsunny
reviewed
Jul 31, 2018
| set_fact: | ||
| intf1: "Ethernet{{ index[1] }}" | ||
| intf2: "Ethernet{{ index[2] }}" | ||
| intf1: "Ethernet{{ index[0] }}" |
Contributor
There was a problem hiding this comment.
I thought index 1 & 2 are valid in t1, t1-64 topology. Are they different?
Contributor
Author
There was a problem hiding this comment.
t1-64 ptf docker only has eth0, eth1, eth4, eth5 ...
prsunny
approved these changes
Jul 31, 2018
jleveque
suggested changes
Jul 31, 2018
ansible/roles/test/tasks/arpall.yml
Outdated
| @@ -15,8 +15,8 @@ | |||
|
|
|||
| - name: select 1&2 two interfaces for test | |||
Contributor
There was a problem hiding this comment.
Update name to reflect change? Select two interfaces for test (0 & 1)
maggiemsft
commented
Aug 15, 2018
| set_fact: | ||
| intf1: "Ethernet{{ index[1] }}" | ||
| intf2: "Ethernet{{ index[2] }}" | ||
| intf1: "Ethernet{{ index[0] }}" |
Contributor
Author
There was a problem hiding this comment.
t1-64 ptf docker only has eth0, eth1, eth4, eth5 ...
| set_fact: | ||
| intf1: "Ethernet{{ index[1] }}" | ||
| intf2: "Ethernet{{ index[2] }}" | ||
| intf1: "Ethernet{{ index[0] }}" |
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
… alpha is disabled (sonic-net#670) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Align the qos test for Mellanox spectrum-4/5 platforms, according to the PR: sonic-net/sonic-buildimage#23381. 1. When port alpha is disabled, we use the common function to calculate the buffer threshold. 2. Update margin for testQosSaiQSharedWatermark[wm_q_shared_lossy] and testQosSaiPgSharedWatermark[wm_pg_shared_lossy] as the following rule: When current margin is smaller share buffer * 0.001, set margin to share buffer * 0.001, otherwise keep the original one Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Align the qos test for Mellanox spc4 and above platform, according to the PR: sonic-net/sonic-buildimage#23381. #### How did you do it? 1. When port alpha is disabled, we use the common function to calculate the buffer threshold. 2. Update margin for testQosSaiQSharedWatermark[wm_q_shared_lossy] and testQosSaiPgSharedWatermark[wm_pg_shared_lossy] as the following rule: When current margin is smaller share buffer * 0.001, set margin to share buffer * 0.001, otherwise keep the original one #### How did you verify/test it? Run qos sai tests on Mellanox spc 4 and above platform #### Any platform specific information? Mellanox spc 4 and above platform #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 54946e9..5b1fa3c: > [neighbor_advertiser] Verify that DIPs returned from ferret are not in device VLAN (sonic-net#670) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…D automatically (#23857) #### Why I did it src/sonic-platform-daemons ``` * 9a2931d - (HEAD -> 202505, origin/202505) Check low power mode before vdm handling (sonic-net#670) (2 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The arpest fail if trying to use ptf-dockers created by t1-64-lag
Type of change
Approach
How did you do it?
change arptest running interfaces
How did you verify/test it?
locally tested for both 32 interface and 64 interfaces topology
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation